Fix encoded taskId check in chatHandlerResource #7520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some of the CI failures look legit, including |
gianm
pushed a commit
to implydata/druid-public
that referenced
this pull request
Apr 21, 2019
* Fix encoded taskId check in chatHandlerResource * fix tests
clintropolis
pushed a commit
that referenced
this pull request
Apr 24, 2019
* Fix encoded taskId check in chatHandlerResource * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChatHandleris an interface to provide RESTful APIs and some tasks are using it to communicate with other Druid modules. When a chatHanlder API is called,ChatHandlerResourcechecks the current running task is the expected callee. Before 0.14, it checkedtaskIdas it is, but after #6761, it encodestaskIdbefore comparing it. This breaks the backwards compatibility, especially when middleManagers of different versions are running in the same cluster. IftaskIddoesn't match,ChatHandlerResourcereturns null which just returnsNOT_FOUNDerror (404) with no message which makes debugging harder.This PR fixes the compatibility issue and improves
ChatHandlerResourceto returnBAD_REQUESTerror with a proper message whentaskIddoesn't match.