-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved UI for actions in task/supervisor table #7528
Conversation
Thanks for the quick turnaround on this, @shuqi7. This is looking great! A couple of UI comments, mockups here for reference:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have a look at grid layouts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor change request
Looking good. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I overall like this change, those tables were very busy, but I'm wondering if perhaps the action buttons, especially 'terminate' and 'suspend'/'resume', are maybe too hidden?
Maybe they would be suited to either be pulled out into their own buttons alongside the info panel, or in some sort of pop-up menu so the things people are likely to do are front and center? Maybe it's fine like this though? I'm not sure either way 🙃
e8b7396
to
aea2fbb
Compare
Made a number of updates to revive this PR and rebased this branch on top of the Data loader (GUI) #7572 changes. Some highlights:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
The original action column in supervisor/task table mixed the conception of information and action; it only open a JSON object in a new tab without prettifying it. It also gets harder to extend the features in the row if we want to add more in the future
![image](https://user-images.githubusercontent.com/29443129/56544394-3e9c3580-6529-11e9-825f-f16a083f9d95.png)
Now: improved UI which combines all the functions into a dialog, that is more functional and easier to extend.
It shows the JSON in a prettified format and allows users to copy and download the JSON, or view the raw JSON
![image](https://user-images.githubusercontent.com/29443129/56603922-a304d680-65b5-11e9-9186-dc8ef0a37dac.png)
![image](https://user-images.githubusercontent.com/29443129/56702868-15abaa00-66bb-11e9-9ff4-3e11bc0be9b7.png)