Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL: Remove "useFallback" feature. #7567

Merged
merged 1 commit into from
Apr 29, 2019
Merged

Commits on Apr 28, 2019

  1. SQL: Remove "useFallback" feature.

    This feature allows Calcite's Bindable interpreter to be bolted on
    top of Druid queries and table scans. I think it should be removed for
    a few reasons:
    
    1. It is not recommended for production anyway, because it generates
    unscalable query plans (e.g. it will plan a join into two table scans
    and then try to do the entire join in memory on the broker).
    2. It doesn't work with Druid-specific SQL functions, like TIME_FLOOR,
    REGEXP_EXTRACT, APPROX_COUNT_DISTINCT, etc.
    3. It makes the SQL planning code needlessly complicated.
    
    With SQL coming out of experimental status soon, it's a good opportunity
    to remove this feature.
    gianm committed Apr 28, 2019
    Configuration menu
    Copy the full SHA
    9643e8d View commit details
    Browse the repository at this point in the history