Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sketches-core-0.13.4 #7666

Merged
merged 1 commit into from
Jun 6, 2019
Merged

Conversation

AlexanderSaydakov
Copy link
Contributor

From the sketches-core release notes:
"0.13.4 May 14, 2019: Fix Theta Direct Union Bug, alternate path.
It turns out there were two different code paths that would reveal the Direct Union Bug. This fixes the alternate, but seldom used path, which wasn't caught in the previous release."

I am not sure this code path is used in Druid. So this update may or may not be of significance.
By the way, did anyone verify that the previous update to 0.13.3 really fixed the Theta sketch regression (#7619)?

@clintropolis
Copy link
Member

By the way, did anyone verify that the previous update to 0.13.3 really fixed the Theta sketch regression (#7619)?

I was no longer able to reproduce the issue after #7619 was applied in my testing.

@gianm gianm merged commit 4dd446b into apache:master Jun 6, 2019
@gianm gianm added this to the 0.16.0 milestone Jun 6, 2019
@clintropolis
Copy link
Member

It would appear that this path must be used at least some of the time: related https://groups.google.com/forum/?pli=1#!topic/druid-user/qCBG7E_zR1c

@jihoonson
Copy link
Contributor

Since the sketches-core version was changed, the LICENSE.BINARY file should have updated in this PR accordingly. This will be automatically checked after #7998.

gianm pushed a commit to implydata/druid-public that referenced this pull request Jul 3, 2019
gianm pushed a commit to implydata/druid-public that referenced this pull request Jul 3, 2019
clintropolis pushed a commit that referenced this pull request Jul 24, 2019
@clintropolis clintropolis modified the milestones: 0.16.0, 0.15.1 Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants