Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing reference to Materialized-View extension. #8003

Merged
merged 2 commits into from
Jul 6, 2019
Merged

Add missing reference to Materialized-View extension. #8003

merged 2 commits into from
Jul 6, 2019

Conversation

yurmix
Copy link
Contributor

@yurmix yurmix commented Jul 1, 2019

No description provided.

@yurmix yurmix changed the title Reference Materialized View extension from extensions page. Add missing reference to Materialized-View extension. Jul 1, 2019
@@ -95,6 +95,7 @@ All of these community extensions can be downloaded using [pull-deps](../operati
|kafka-emitter|Kafka metrics emitter|[link](../development/extensions-contrib/kafka-emitter.html)|
|druid-thrift-extensions|Support thrift ingestion |[link](../development/extensions-contrib/thrift.html)|
|druid-opentsdb-emitter|OpenTSDB metrics emitter |[link](../development/extensions-contrib/opentsdb-emitter.html)|
|materialized-view-selection materialized-view-maintenance|Materialized View|[link](../development/extensions-contrib/materialized-view.html)|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please add a comma between them? Or perhaps itemizing them is better? Not sure it's possible in the table.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, I kept the space as well for beautification reasons (Here, it creates two lines in the same cell).

Copy link
Contributor Author

@yurmix yurmix Jul 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll keep it like that, but BTW it is possible to itemize:

Name Description Docs
  • materialized-view-selection
  • materialized-view-maintenance
Materialized View link

<ul><li>materialized-view-selection</li><li>materialized-view-maintenance</li></ul>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool thanks!

@jihoonson jihoonson merged commit 2eee711 into apache:master Jul 6, 2019
@yurmix yurmix deleted the missing-extension-link branch July 10, 2019 20:31
clintropolis pushed a commit that referenced this pull request Jul 24, 2019
* Reference Materialized View extension from extensions page.

* Add comma
@clintropolis clintropolis added this to the 0.15.1 milestone Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants