-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Apache Thrift to 0.10.0 #8419
Conversation
…mp-to-thrift-0-10-0
Rebased onto master |
…mp-to-thrift-0-10-0
…mp-to-thrift-0-10-0
…mp-to-thrift-0-10-0
…mp-to-thrift-0-10-0
…mp-to-thrift-0-10-0
+1 after CI. LGTM and Teamcity are failing because of the missing libthrift-0.5.0-1 jar. I think we can solve this by simply updating the version of This PR will make Travis failed because it's not updating |
Why is this a development blocker? |
The old version of |
It actually might not, the old version doesn't appear to be in |
Thanks, updating scrooge should fix the dependency on the ancient version of libthrift indeed. Jenkins is running on my fork as well: https://travis-ci.org/Fokko/druid/builds/607854795 The one on Apache is still pending due to capacity issues. |
Responding to myself, but I don't think we need to worry about updating |
The LGTM is failing with the same error even after I restarted once. Since TeamCity looks fine, I think it's an issue with LGTM (maybe it's caching something). I'll merge this PR shortly and will see other builds succeed. |
* Bump Apache Thrift to 0.10.0 * Remove unused dependency * Bump maven-scrooge-plugin to the latest
* Bump Apache Thrift to 0.10.0 * Remove unused dependency * Bump maven-scrooge-plugin to the latest
* Bump Apache Thrift to 0.10.0 * Remove unused dependency * Bump maven-scrooge-plugin to the latest
* Bump Apache Thrift to 0.10.0 * Remove unused dependency * Bump maven-scrooge-plugin to the latest
Bump Apache Thrift to at least 0.10.0 for now. https://github.com/apache/thrift/blob/master/CHANGES.md#0100
Description
This PR has: