Startup scripts: verify Java 8 (exactly), improve port/java verification messages. #8794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion messages. Java 11 compatibility isn't fully baked yet (users have reported various issues on Java 11), so block startup with an error message unless Java 8 is found. Allow overriding this decision with an environment variable.
suneet-s
approved these changes
Oct 31, 2019
examples/bin/verify-java
Outdated
| sub fail_check { | ||
| my ($current_version) = @_; | ||
| my $current_version_text = | ||
| $current_version ? " Your current version is: $current_version." : ""; |
There was a problem hiding this comment.
nit: would be nice to have the error message say something along the lines of java isn't on the PATH for the else case
There was a problem hiding this comment.
Good idea, I added Make sure that "java" is installed and on your PATH.
examples/bin/verify-default-ports
Outdated
|
|
||
| export DRUID_SKIP_PORT_CHECK=1 | ||
|
|
||
| Otherwise, free up port $port and try again. |
There was a problem hiding this comment.
nit: Would be nice to link to https://druid.apache.org/docs/latest/configuration/index.html for more details on changing the ports / what the different ports are used for.
There was a problem hiding this comment.
I made some adjustments, let me know what you think.
|
Thanks for this fix! |
clintropolis
approved these changes
Oct 31, 2019
gianm
added a commit
to gianm/druid
that referenced
this pull request
Oct 31, 2019
Accidentally missed some quote escaping in apache#8794.
Merged
gianm
added a commit
that referenced
this pull request
Oct 31, 2019
Accidentally missed some quote escaping in #8794.
jon-wei
pushed a commit
to implydata/druid-public
that referenced
this pull request
Nov 25, 2019
…ion messages. (apache#8794) * Startup scripts: verify Java 8 (exactly), improve port/java verification messages. Java 11 compatibility isn't fully baked yet (users have reported various issues on Java 11), so block startup with an error message unless Java 8 is found. Allow overriding this decision with an environment variable. * Message adjustments.
jon-wei
pushed a commit
to jon-wei/druid
that referenced
this pull request
Nov 27, 2019
…ion messages. (apache#8794) * Startup scripts: verify Java 8 (exactly), improve port/java verification messages. Java 11 compatibility isn't fully baked yet (users have reported various issues on Java 11), so block startup with an error message unless Java 8 is found. Allow overriding this decision with an environment variable. * Message adjustments.
jon-wei
added a commit
that referenced
this pull request
Nov 27, 2019
…ion messages. (#8794) (#8951) * Startup scripts: verify Java 8 (exactly), improve port/java verification messages. Java 11 compatibility isn't fully baked yet (users have reported various issues on Java 11), so block startup with an error message unless Java 8 is found. Allow overriding this decision with an environment variable. * Message adjustments.
jon-wei
pushed a commit
to jon-wei/druid
that referenced
this pull request
Nov 28, 2019
Accidentally missed some quote escaping in apache#8794.
jon-wei
added a commit
that referenced
this pull request
Nov 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java 11 compatibility isn't fully baked yet (users have reported various
issues on Java 11), so block startup with an error message unless Java 8
is found. Allow overriding this decision with an environment variable.