Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: navigation between services and tests. Fixes #285 #286

Merged
merged 2 commits into from
Feb 12, 2019
Merged

feature: navigation between services and tests. Fixes #285 #286

merged 2 commits into from
Feb 12, 2019

Conversation

kezhenxu94
Copy link
Member

@kezhenxu94 kezhenxu94 commented Jan 31, 2019

Modifications:

  • Add links to Service Test in Service List

image

  • Using autocomplete input component to give suggestions to users and support fuzzy search

image

Related issue: #285

@codecov-io
Copy link

codecov-io commented Jan 31, 2019

Codecov Report

Merging #286 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #286   +/-   ##
==========================================
  Coverage      19.37%   19.37%           
  Complexity       289      289           
==========================================
  Files             91       91           
  Lines           3639     3639           
  Branches         566      566           
==========================================
  Hits             705      705           
  Misses          2859     2859           
  Partials          75       75

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87669fd...169eb83. Read the comment docs.

@kezhenxu94
Copy link
Member Author

kezhenxu94 commented Feb 1, 2019

And I suggest splitting the i18n language file to individual files acccording to different modules, because:

  • there are chances that different messages with same key are required in different modules

  • it would be more contextual for people who wants to localize to their language

@nzomkxia WDYT? If it's good, I'll open another issue.

@nzomkxia
Copy link
Member

And I suggest splitting the i18n language file to individual files acccording to different modules, because:

  • there are chances that different messages with same key are required in different modules
  • it would be more contextual for people who wants to localize to their language

@nzomkxia WDYT? If it's good, I'll open another issue.

sorry for the late reply, I think it's a good advice, please open another issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants