Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service test for dubbo2.6 & fix #305 #308

Closed

Conversation

qq925716471
Copy link
Contributor

fix #305
服务测试支持dubbo2.6
修改服务测试查询实现方式减少后台请求
修改泛化调用bug

…o2.6

# Conflicts:
#	dubbo-admin-server/src/main/java/org/apache/dubbo/admin/service/impl/GenericServiceImpl.java
@nzomkxia
Copy link
Member

@qq925716471 Service test for dubbo 2.6 is impossible, since Dubbo 2.6 do not have metadata info

@codecov-io
Copy link

codecov-io commented Feb 15, 2019

Codecov Report

Merging #308 into develop will decrease coverage by 0.25%.
The diff coverage is 3.22%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #308      +/-   ##
=============================================
- Coverage      19.57%   19.31%   -0.26%     
  Complexity       289      289              
=============================================
  Files             95       95              
  Lines           3582     3603      +21     
  Branches         553      558       +5     
=============================================
- Hits             701      696       -5     
- Misses          2806     2832      +26     
  Partials          75       75
Impacted Files Coverage Δ Complexity Δ
...e/dubbo/admin/service/impl/GenericServiceImpl.java 5.88% <3.22%> (-47.97%) 2 <1> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bc0e33...6f64733. Read the comment docs.

qq925716471 and others added 3 commits February 18, 2019 17:17
…o2.6

# Conflicts:
#	dubbo-admin-server/src/main/java/org/apache/dubbo/admin/service/impl/GenericServiceImpl.java
@qq925716471 qq925716471 reopened this Feb 18, 2019
@qq925716471 qq925716471 deleted the serviceTestForDubbo2.6 branch February 18, 2019 09:35
@nzomkxia
Copy link
Member

Hi @qq925716471 the pr #306 has been accepted to fix #305, can you remove this part in your pr?

@qq925716471
Copy link
Contributor Author

#311

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

服务测试 invoke通过setInterface,方法reference.get()无法正确获取服务代理
3 participants