Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: listen on random local port #37

Merged
merged 6 commits into from Apr 24, 2020
Merged

Add: listen on random local port #37

merged 6 commits into from Apr 24, 2020

Conversation

AlexStocks
Copy link

1 udp/tcp server listen on random local port;
2 using perrors.WithStack in log

@auto-comment
Copy link

auto-comment bot commented Apr 23, 2020

Thank your for raising your pull request.
Please make sure you have followed our contributing guidelines. We will review it as soon as possible

@AlexStocks AlexStocks closed this Apr 23, 2020
@AlexStocks AlexStocks reopened this Apr 23, 2020
zouyx
zouyx approved these changes Apr 23, 2020
View reviewed changes
server.go Outdated Show resolved Hide resolved
server.go Outdated Show resolved Hide resolved
wongoo
wongoo approved these changes Apr 23, 2020
View reviewed changes
Copy link

@wongoo wongoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wongoo
Copy link

wongoo commented Apr 24, 2020 

go fmt ./... && [[ -z `git status -s` ]]
session.go
The command "go fmt ./... && [[ -z `git status -s` ]]" exited with 1.

pls format the code session.go

@AlexStocks
Copy link
Author 

go fmt ./... && [[ -z `git status -s` ]]

done

@wongoo wongoo merged commit 076a806 into apache:master Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zouyx zouyx zouyx approved these changes

@wongoo wongoo wongoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AlexStocks @wongoo @zouyx