Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ftr: add BigInteger support #141

Merged
merged 24 commits into from Dec 14, 2019
Merged

Ftr: add BigInteger support #141

merged 24 commits into from Dec 14, 2019

Conversation

micln
Copy link
Contributor

@micln micln commented Nov 27, 2019

What this PR does: mapping java/bigInteger to go/big.Int

Does this PR introduce a user-facing change?: no


@micln micln changed the title Feature/add decimal support WIP: Feature/add decimal support Nov 27, 2019
@micln micln changed the title WIP: Feature/add decimal support WIP: Feature/add integer support Nov 27, 2019
test_hessian/src/main/java/test/TestCustomDecode.java Outdated Show resolved Hide resolved
serialize_test.go Outdated Show resolved Hide resolved
date_test.go Outdated Show resolved Hide resolved
@wongoo
Copy link
Contributor

wongoo commented Nov 27, 2019

this pr depends on the pr of gost, which must be merged and release a new version first.

go.mod Outdated Show resolved Hide resolved
@wongoo
Copy link
Contributor

wongoo commented Dec 4, 2019

LGTM

@wongoo
Copy link
Contributor

wongoo commented Dec 9, 2019

@micln do u have more unit tests to commit? I'd like to merge it if nothing.

@micln
Copy link
Contributor Author

micln commented Dec 9, 2019

@wongoo sorry I will finish it tonight

Squashed commits:
[b79f255] gost v1.4
[5426989] update gost
[3d6bede] fmt go.mod
[9cfdf3f] revert ci
[bcdff98] fix gitstatus ci
[6300d8f] show git status
[2edd71d] go sum
[642d7db] java test code
[f8ea1b6] fix test gomod
[b433ee4] for test gomod
[2807b16] integer serializer
[f26cda4] register big.int
[7034283] rename variants in go code
[6d00a06] rename variant name
[e850c66] remove "List" in function name and merge doTestTypes
[32a51e3] Feature/add decimal support
@wongoo wongoo changed the title WIP: Feature/add integer support Ftr: add BigInteger support Dec 11, 2019
@wongoo
Copy link
Contributor

wongoo commented Dec 11, 2019

@micln the bug that can't decoding BigInteger array fixed by #144

serialize.go Show resolved Hide resolved
serialize.go Outdated Show resolved Hide resolved
date_test.go Outdated Show resolved Hide resolved
serialize.go Outdated Show resolved Hide resolved
serialize_test.go Show resolved Hide resolved
@wongoo wongoo merged commit d24d44e into apache:master Dec 14, 2019
zhaoyunxing92 pushed a commit that referenced this pull request Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants