Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore fields #201

Merged
merged 9 commits into from
Jun 12, 2020
Merged

Ignore fields #201

merged 9 commits into from
Jun 12, 2020

Conversation

fangyincheng
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2020

Codecov Report

Merging #201 into master will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #201      +/-   ##
==========================================
+ Coverage   66.39%   66.50%   +0.10%     
==========================================
  Files          22       22              
  Lines        2845     2836       -9     
==========================================
- Hits         1889     1886       -3     
+ Misses        740      737       -3     
+ Partials      216      213       -3     
Impacted Files Coverage Δ
object.go 66.97% <100.00%> (+0.72%) ⬆️
string.go 57.91% <0.00%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7b44b5...df992eb. Read the comment docs.

Copy link
Contributor

@wongoo wongoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we make skipping fields which not exists as the default behavior? does hessian java do that?

codec.go Outdated Show resolved Hide resolved
@fangyincheng
Copy link
Contributor Author

should we make skipping fields which not exists as the default behavior? does hessian java do that?

I think we can discuss with everyone, in the group.

object.go Outdated Show resolved Hide resolved
object.go Outdated Show resolved Hide resolved
codec.go Outdated Show resolved Hide resolved
@wongoo
Copy link
Contributor

wongoo commented Jun 10, 2020

既然java都默认忽略不存在字段,那这个pr就没什么大问题了,修改一下comment的问题即可。

Copy link
Contributor

@wongoo wongoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wongoo wongoo requested review from AlexStocks and hxmhlt June 11, 2020 01:05
object_test.go Outdated Show resolved Hide resolved
@AlexStocks AlexStocks merged commit 6e2b22b into apache:master Jun 12, 2020
zhaoyunxing92 pushed a commit that referenced this pull request Sep 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants