Ftr: catch exceptions that user defined #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cvictory can u add a unit test that the exception data is from java, there are many ut samples in this project which decode bytes generated by java. |
增加了java的异常返回结果的用例，数据存在test_reource目录下的两个文件。 |
AlexStocks
approved these changes
Jul 6, 2020
hxmhlt
reviewed
Jul 9, 2020
test_resource/RuntimeException.txt
Outdated
| @@ -0,0 +1,5 @@ | |||
| Cjava.lang.RuntimeException�detailMessagecause | |||
| stackTracesuppressedExceptions` test exceptQ�V [java.lang.StackTraceElement�?Cjava.lang.StackTraceElement�declaringClass | |||
|
@cvictory sorry for delay reply. DO NOT add binary data into, which can't be checked, u can test java response easily, ref https://github.com/apache/dubbo-go-hessian2/blob/master/decode_test.go#L93 |
fangyincheng
approved these changes
Jul 11, 2020
zouyx
approved these changes
Jul 12, 2020
| "github.com/apache/dubbo-go-hessian2/java_exception" | ||
| ) | ||
|
|
||
| var mutex sync.Mutex |
There was a problem hiding this comment.
I think should make this variable name more meaningful, like getExceptionMutex, checkExceptionMutex etc?
Closed
zhangymPerson
added a commit
to zhangymPerson/dubbo-go-hessian2
that referenced
this pull request
Sep 12, 2020
add support java8 time object. apache#212, apache#221
AlexStocks
added a commit
that referenced
this pull request
Sep 22, 2020
add catch user defined exceptions. #208
zhaoyunxing92
pushed a commit
that referenced
this pull request
Sep 4, 2021
Ftr: catch exceptions that user defined
zhaoyunxing92
pushed a commit
that referenced
this pull request
Sep 4, 2021
add catch user defined exceptions. #208
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.当java抛出自定义业务异常的时候，当dubb-go client没有注册这个异常类型，这时候会出现错误。
这里会将这种异常统一转换为BizException。
2.原来的stackTraceElement数据丢失，进行修复。
之前的pr ： #204 ，不小心在本地push错远程仓库，直接推进去了。 从代码层面进行了回滚，所以重新提交下PR。