Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java.util.Locale support #264

Merged
merged 34 commits into from
Apr 20, 2021
Merged

Java.util.Locale support #264

merged 34 commits into from
Apr 20, 2021

Conversation

zhangymPerson
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:

Fixes #230

Special notes for your reviewer:add go struct Locale

Does this PR introduce a user-facing change?:

add go struct Locale

zouyixian and others added 28 commits March 28, 2020 13:59
# Conflicts:
#	java8_time.go
#	java8_time/year.go
#	java8_time_test.go
#	test_hessian/src/main/java/test/Hessian.java
#	test_hessian/src/main/java/test/TestJava8Time.java
@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2021

Codecov Report

Merging #264 (368b46a) into master (0d0b707) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
+ Coverage   67.40%   67.44%   +0.03%     
==========================================
  Files          26       26              
  Lines        2663     2666       +3     
==========================================
+ Hits         1795     1798       +3     
  Misses        649      649              
  Partials      219      219              
Impacted Files Coverage Δ
java_util.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d0b707...368b46a. Read the comment docs.

java_util/locale.go Outdated Show resolved Hide resolved
java_util/locale.go Outdated Show resolved Hide resolved
java_util/locale.go Outdated Show resolved Hide resolved
java_util/locale.go Outdated Show resolved Hide resolved
@wongoo wongoo changed the title Java.util Java.util.Locale support Apr 19, 2021
Copy link
Contributor

@wongoo wongoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wongoo wongoo merged commit b16a9bd into apache:master Apr 20, 2021
zhaoyunxing92 pushed a commit that referenced this pull request Sep 4, 2021
* add license checker

* dd javaProject java8time test code and add go hessian/java8_time strcut Year and testFunc

* alter author and error word

* add java.util.UUID encode

* Revert "reset go.mod after go fmt"

This reverts commit ab7254f

* add UUID test

* alter .travis.yml

* alter code

* add license

* shift count type int, must be unsigned integer

* alter file name and delete test file

* alter file name

* delete file

* alter file name

* alter file name

* add uuid struct info and split import block.

* add java UUID encode and uuid.toString() equals go uuid.ToString() test func

* alter ToString() -> String()

* fix code review

* add go struct Locale = java:java.util.Locale

* alter Locales is const slice

* alter Locales add clearer definition

* alter locales is private

* add ToLocale() and localeMap

* delete fmt.Sprintf()

* alter Locale struct field unexported

Co-authored-by: zouyixian <zouyixian@shein.com>
Co-authored-by: wilson chen <willson.chenwx@gmail.com>
Co-authored-by: wangoo <wongoo@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Go struct refer to java.util.Locale
4 participants