Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(*): support wrapper classes for Java basic types #278

Merged
merged 6 commits into from Sep 17, 2021

Conversation

Mulavar
Copy link
Member

@Mulavar Mulavar commented Sep 13, 2021

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@Mulavar Mulavar changed the title [WIP]feat(*): add Integer[] serializer feat(*): support wrapper classes for Java basic types Sep 13, 2021
array.go Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2021

Codecov Report

Merging #278 (9aafe3b) into master (8679ff8) will increase coverage by 1.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #278      +/-   ##
==========================================
+ Coverage   68.87%   70.09%   +1.21%     
==========================================
  Files          26       27       +1     
  Lines        2911     3016     +105     
==========================================
+ Hits         2005     2114     +109     
+ Misses        683      677       -6     
- Partials      223      225       +2     
Impacted Files Coverage Δ
array.go 100.00% <100.00%> (ø)
java_collection.go 58.90% <0.00%> (+5.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8679ff8...9aafe3b. Read the comment docs.

array_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@wongoo wongoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mulavar use Encoder to test encode in unit tests please.

array.go Outdated Show resolved Hide resolved
@wongoo
Copy link
Contributor

wongoo commented Sep 16, 2021

@Mulavar thanks for your effort. wrapper classes is mainly for java, so the unit test should contains cross language encode/decode. Pls pay more time to do that, thanks very much!

eg:

go encode -> java decode:

java encode-> go decode:

@wongoo wongoo requested a review from zouyx September 17, 2021 09:24
@AlexStocks AlexStocks merged commit 74a8ece into apache:master Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants