Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix registration ignored for struct with same name in diff package #279

Conversation

ChangedenCZD
Copy link
Contributor

What this PR does:
Optimizing the registration go struct name (combine go PkgPath and go Name).

Which issue(s) this PR fixes:

Fixes apache/dubbo-go#1454

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@ChangedenCZD
Copy link
Contributor Author

@wongoo 如果不考虑JavaClassName重复注册的话,dubbo-go无须变动

@wongoo
Copy link
Contributor

wongoo commented Sep 18, 2021

@wongoo 如果不考虑JavaClassName重复注册的话,dubbo-go无须变动

暂不考虑,重复JavaClassName的问题应该在象模型设计上就做好区分。

@ChangedenCZD
Copy link
Contributor Author

涉及的面有点多,暂时先关闭

@ChangedenCZD ChangedenCZD reopened this Sep 22, 2021
pojo.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2021

Codecov Report

Merging #279 (4d5ca70) into master (74a8ece) will increase coverage by 0.11%.
The diff coverage is 100.00%.

❗ Current head 4d5ca70 differs from pull request most recent head 8959733. Consider uploading reports for the commit 8959733 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #279      +/-   ##
==========================================
+ Coverage   70.09%   70.21%   +0.11%     
==========================================
  Files          27       27              
  Lines        3016     3028      +12     
==========================================
+ Hits         2114     2126      +12     
  Misses        677      677              
  Partials      225      225              
Impacted Files Coverage Δ
list.go 84.61% <100.00%> (+0.06%) ⬆️
pojo.go 63.59% <100.00%> (+2.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74a8ece...8959733. Read the comment docs.

pojo.go Outdated Show resolved Hide resolved
@AlexStocks
Copy link
Contributor

Pls add unit tests for this pr. maybe some uts for the two new funcs.

@AlexStocks AlexStocks merged commit a0c5132 into apache:master Sep 25, 2021
AlexStocks added a commit that referenced this pull request Oct 11, 2021
…st_module_name

Fix: modify pr #279 unit test requires module name
@wongoo wongoo changed the title Fix: dobbo-go issue #1454 fix registration ignored for struct with same name in diff package Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go中不同package里的数据结构,不应该因为同名而引起异常
4 participants