Refractor config_load.go #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexStocks
reviewed
Apr 25, 2021
AlexStocks
reviewed
Apr 25, 2021
Codecov Report
@@ Coverage Diff @@
## develop #158 +/- ##
===========================================
+ Coverage 42.99% 43.19% +0.19%
===========================================
Files 33 33
Lines 1742 1755 +13
===========================================
+ Hits 749 758 +9
+ Misses 890 888 -2
- Partials 103 109 +6
Continue to review full report at Codecov.
|
AlexStocks
reviewed
Apr 25, 2021
xiaoliu10
approved these changes
May 22, 2021
AlexStocks
approved these changes
May 28, 2021
mark4z
pushed a commit
that referenced
this pull request
Nov 7, 2021
* Refractor config_load.go * Refractor pixiu_start.go * Refractor pixiu_start.go * bug fix about read yml file. some key with _ can't read in object. * Change DiscoverService to DiscoveryService. Co-authored-by: zhangxun <18721825717@163.com> Former-commit-id: 51bb439
tydhot
pushed a commit
to tydhot/dubbo-go-pixiu
that referenced
this pull request
Nov 10, 2021
* Refractor config_load.go * Refractor pixiu_start.go * Refractor pixiu_start.go * bug fix about read yml file. some key with _ can't read in object. * Change DiscoverService to DiscoveryService. Co-authored-by: zhangxun <18721825717@163.com> Former-commit-id: b3940bb [formerly 51bb439] Former-commit-id: 15c079b
bobtthp
pushed a commit
to bobtthp/dubbo-go-pixiu
that referenced
this pull request
Dec 12, 2022
* Refractor config_load.go * Refractor pixiu_start.go * Refractor pixiu_start.go * bug fix about read yml file. some key with _ can't read in object. * Change DiscoverService to DiscoveryService. Co-authored-by: zhangxun <18721825717@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yamlfile with "_" can not convert into object, I solve this by adding mapstructre mapping in related model file.config_load.go.