Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve: expand filterFuncCacheMap initial length #174

Merged
merged 2 commits into from
May 23, 2021

Conversation

alchemy-lee
Copy link
Contributor

What this PR does:

  1. pixiu initializes 7 filters in init.Run() function, but the initial value of filterFuncCacheMap is 4, it should be changed to 8.
  2. the GenericServicePool has been initialized twice in NewDubboClient() and Init(), we can omit the second initialization.

Does this PR introduce a user-facing change?:

NO

@alchemy-lee alchemy-lee changed the title Init fix Fix some issues about the initialization May 21, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 22, 2021

Codecov Report

Merging #174 (2841428) into develop (1ee7018) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #174      +/-   ##
===========================================
+ Coverage    42.28%   42.30%   +0.02%     
===========================================
  Files           33       33              
  Lines         1743     1742       -1     
===========================================
  Hits           737      737              
+ Misses         905      904       -1     
  Partials       101      101              
Impacted Files Coverage Δ
pkg/client/dubbo/dubbo.go 21.15% <ø> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ee7018...2841428. Read the comment docs.

@AlexStocks AlexStocks changed the title Fix some issues about the initialization Improve: expand filterFuncCacheMap initial length May 22, 2021
@xiaoliu10 xiaoliu10 merged commit 2173648 into apache:develop May 23, 2021
@xiaoliu10 xiaoliu10 added this to the v0.2.1 milestone May 29, 2021
@alchemy-lee alchemy-lee deleted the init_fix branch September 28, 2021 01:36
mark4z pushed a commit that referenced this pull request Nov 7, 2021
tydhot pushed a commit to tydhot/dubbo-go-pixiu that referenced this pull request Nov 10, 2021
Former-commit-id: 18deed6 [formerly 2173648]
Former-commit-id: f6bb243
bobtthp pushed a commit to bobtthp/dubbo-go-pixiu that referenced this pull request Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants