Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timeout config overridden #190

Merged
merged 4 commits into from
Jun 22, 2021
Merged

Conversation

alchemy-lee
Copy link
Contributor

What this PR does:

This PR moves the timeout config outside the clusters. In detail, it moves connect_timeout and request_timeout from clusters into timeout_config in conf.yaml.

Which issue(s) this PR fixes:

Fixes #189

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2021

Codecov Report

Merging #190 (9cd9bb7) into develop (5c98b5e) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #190      +/-   ##
===========================================
- Coverage    43.19%   43.14%   -0.05%     
===========================================
  Files           33       33              
  Lines         1755     1757       +2     
===========================================
  Hits           758      758              
- Misses         888      890       +2     
  Partials       109      109              
Impacted Files Coverage Δ
pkg/client/dubbo/dubbo.go 20.75% <0.00%> (-0.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c98b5e...9cd9bb7. Read the comment docs.

@alchemy-lee alchemy-lee changed the title Timeout2 Fix timeout config overridden Jun 15, 2021
@xiaoliu10 xiaoliu10 merged commit 73949d3 into apache:develop Jun 22, 2021
@xiaoliu10 xiaoliu10 added this to WIP in v0.3.0 via automation Jul 2, 2021
@xiaoliu10 xiaoliu10 added this to the v0.3.0 milestone Jul 2, 2021
@alchemy-lee alchemy-lee deleted the timeout2 branch September 28, 2021 01:36
mark4z pushed a commit that referenced this pull request Nov 7, 2021
tydhot pushed a commit to tydhot/dubbo-go-pixiu that referenced this pull request Nov 10, 2021
Former-commit-id: 7031a5e [formerly 73949d3]
Former-commit-id: 329af05
bobtthp pushed a commit to bobtthp/dubbo-go-pixiu that referenced this pull request Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

If we configure more than one clusters in conf.yaml, the timeout field of former cluster will be overridden
5 participants