Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/quickstart #191

Merged
merged 3 commits into from
Jun 23, 2021
Merged

Fix/quickstart #191

merged 3 commits into from
Jun 23, 2021

Conversation

PhilYue
Copy link
Member

@PhilYue PhilYue commented Jun 18, 2021

What this PR does:
Fix Quick Start !

Which issue(s) this PR fixes:
NONE
Fixes #

Special notes for your reviewer:

  • fix the Makefile, for quick start by tutorial
  • fix the quick start script under the docs directory

Does this PR introduce a user-facing change?:
NONE

@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2021 •
edited
Loading

Codecov Report

Merging #191 (0c440b5) into develop (5c98b5e) will not change coverage.
The diff coverage is n/a.

❗ Current head 0c440b5 differs from pull request most recent head efff69f. Consider uploading reports for the commit efff69f to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #191   +/-   ##
========================================
  Coverage    43.19%   43.19%           
========================================
  Files           33       33           
  Lines         1755     1755           
========================================
  Hits           758      758           
  Misses         888      888           
  Partials       109      109

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c98b5e...efff69f. Read the comment docs.

@AlexStocks AlexStocks merged commit 4bae729 into apache:develop Jun 23, 2021
@xiaoliu10 xiaoliu10 added this to WIP in v0.3.0 via automation Jul 2, 2021
@xiaoliu10 xiaoliu10 added this to the v0.3.0 milestone Jul 2, 2021
mark4z pushed a commit that referenced this pull request Nov 7, 2021
@AlexStocks
Merge pull request #191 from PhilYue/fix/quickstart
428ae47 
Fix/quickstart

Former-commit-id: 4bae729
tydhot pushed a commit to tydhot/dubbo-go-pixiu that referenced this pull request Nov 10, 2021
@AlexStocks
Merge pull request apache#191 from PhilYue/fix/quickstart
3bd8c3d 
Fix/quickstart

Former-commit-id: 428ae47 [formerly 4bae729]
Former-commit-id: a7b89d1
bobtthp pushed a commit to bobtthp/dubbo-go-pixiu that referenced this pull request Dec 12, 2022
@AlexStocks
Merge pull request apache#191 from PhilYue/fix/quickstart
d4b5321 
Fix/quickstart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexStocks AlexStocks AlexStocks approved these changes

@zhangshen023 zhangshen023 zhangshen023 approved these changes

@xiaoliu10 xiaoliu10 xiaoliu10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
v0.3.0
WIP
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@PhilYue @codecov-commenter @AlexStocks @zhangshen023 @xiaoliu10