Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reviewdog #195

Merged
merged 9 commits into from
Jul 1, 2021
Merged

Fix reviewdog #195

merged 9 commits into from
Jul 1, 2021

Conversation

ztelur
Copy link
Contributor

@ztelur ztelur commented Jun 25, 2021 •
edited
Loading

What this PR does:

  • lowercase path key
  • Fix reviewdog

image

@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2021 •
edited
Loading

Codecov Report

Merging #195 (1d2d50a) into develop (d4d0ad3) will not change coverage.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #195   +/-   ##
========================================
  Coverage    38.09%   38.09%           
========================================
  Files           36       36           
  Lines         1848     1848           
========================================
  Hits           704      704           
  Misses        1048     1048           
  Partials        96       96
Impacted Files Coverage Δ
pkg/config/api_config.go 3.51% <0.00%> (+0.01%) ⬆️
pkg/pixiu/pixiu_start.go 0.00% <0.00%> (ø)
pkg/service/api/discovery_service.go 43.13% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4d0ad3...1d2d50a. Read the comment docs.

@xiaoliu10 xiaoliu10 merged commit da865b0 into apache:develop Jul 1, 2021
@xiaoliu10 xiaoliu10 added this to WIP in v0.3.0 via automation Jul 2, 2021
@xiaoliu10 xiaoliu10 added this to the v0.3.0 milestone Jul 2, 2021
mark4z pushed a commit that referenced this pull request Nov 7, 2021
@ztelur @kezhenxu94
Fix reviewdog (#195)
7e96e4a 
* fix reviewdog problem

* fix ci

* lowercase path key

Co-authored-by: kezhenxu94 <kezhenxu94@apache.org>
Former-commit-id: da865b0
tydhot pushed a commit to tydhot/dubbo-go-pixiu that referenced this pull request Nov 10, 2021
@ztelur @kezhenxu94
Fix reviewdog (apache#195)
a797bf4 
* fix reviewdog problem

* fix ci

* lowercase path key

Co-authored-by: kezhenxu94 <kezhenxu94@apache.org>
Former-commit-id: 7e96e4a [formerly da865b0]
Former-commit-id: d7496a9
bobtthp pushed a commit to bobtthp/dubbo-go-pixiu that referenced this pull request Dec 12, 2022
@ztelur @kezhenxu94
Fix reviewdog (apache#195)
8c7e353 
* fix reviewdog problem

* fix ci

* lowercase path key

Co-authored-by: kezhenxu94 <kezhenxu94@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexStocks AlexStocks AlexStocks approved these changes

@xiaoliu10 xiaoliu10 xiaoliu10 approved these changes

@mark4z mark4z mark4z approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
v0.3.0
WIP
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ztelur @codecov-commenter @AlexStocks @xiaoliu10 @mark4z @kezhenxu94