Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update samples/admin #208

Merged
merged 4 commits into from
Jul 12, 2021
Merged

update samples/admin #208

merged 4 commits into from
Jul 12, 2021

Conversation

ztelur
Copy link
Contributor

@ztelur ztelur commented Jul 10, 2021

What this PR does:

  • update samples/admin by deleting old project and adding yuque document link
  • add return statement after handling method config put event

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2021 •
edited
Loading

Codecov Report

Merging #208 (b16f10b) into develop (2ced699) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #208      +/-   ##
===========================================
- Coverage    40.35%   40.33%   -0.02%     
===========================================
  Files           39       39              
  Lines         2354     2355       +1     
===========================================
  Hits           950      950              
- Misses        1302     1303       +1     
  Partials       102      102
Impacted Files Coverage Δ
pkg/config/api_config.go 2.47% <0.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ced699...b16f10b. Read the comment docs.

@xiaoliu10 xiaoliu10 merged commit a4f790b into apache:develop Jul 12, 2021
mark4z pushed a commit that referenced this pull request Nov 7, 2021
@ztelur @xiaoliu10
update samples/admin (#208)
a48f7f3 
* delete old samples/admin

* recovery

Co-authored-by: zhangxun <18721825717@163.com>
Former-commit-id: a4f790b
tydhot pushed a commit to tydhot/dubbo-go-pixiu that referenced this pull request Nov 10, 2021
@ztelur @xiaoliu10
update samples/admin (apache#208)
6150f65 
* delete old samples/admin

* recovery

Co-authored-by: zhangxun <18721825717@163.com>
Former-commit-id: a48f7f3 [formerly a4f790b]
Former-commit-id: b04148d
bobtthp pushed a commit to bobtthp/dubbo-go-pixiu that referenced this pull request Dec 12, 2022
@ztelur @xiaoliu10
update samples/admin (apache#208)
b38118f 
* delete old samples/admin

* recovery

Co-authored-by: zhangxun <18721825717@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexStocks AlexStocks AlexStocks approved these changes

@williamfeng323 williamfeng323 williamfeng323 approved these changes

@xiaoliu10 xiaoliu10 xiaoliu10 approved these changes

@mark4z mark4z mark4z approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ztelur @codecov-commenter @AlexStocks @williamfeng323 @xiaoliu10 @mark4z