Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gateway support for HTTPS #213

Merged
merged 18 commits into from
Aug 8, 2021
Merged

Conversation

zhaoyadong00
Copy link
Contributor

@zhaoyadong00 zhaoyadong00 commented Jul 15, 2021

What this PR does:
The gateway supports external access to HTTPS.
Which issue(s) this PR fixes:
HTTPS is more secure. It is recommended to use HTTPS.

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@zhaoyadong00 zhaoyadong00 changed the title Ver https Add gateway support for HTTPS Jul 16, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2021

Codecov Report

Merging #213 (72f8a70) into develop (ac2c232) will increase coverage by 0.05%.
The diff coverage is 4.16%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #213      +/-   ##
===========================================
+ Coverage    40.50%   40.56%   +0.05%     
===========================================
  Files           39       39              
  Lines         2264     2283      +19     
===========================================
+ Hits           917      926       +9     
- Misses        1255     1267      +12     
+ Partials        92       90       -2     
Impacted Files Coverage Δ
pkg/pixiu/listener.go 17.32% <0.00%> (-2.87%) ⬇️
pkg/pixiu/pixiu_start.go 0.00% <0.00%> (ø)
pkg/config/config_load.go 70.37% <100.00%> (+7.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac2c232...72f8a70. Read the comment docs.

@AlexStocks AlexStocks requested review from cityiron and xiaoliu10 and removed request for cityiron July 18, 2021 16:18
@zhaoyadong00 zhaoyadong00 marked this pull request as draft August 2, 2021 07:46
@zhaoyadong00
Copy link
Contributor Author

@cityiron 帮review一下,看还有哪里需要修改的。

@xiaoliu10 xiaoliu10 marked this pull request as ready for review August 8, 2021 08:48
@williamfeng323 williamfeng323 merged commit 21d1957 into apache:develop Aug 8, 2021
mark4z pushed a commit that referenced this pull request Nov 7, 2021
Add gateway support for HTTPS

Former-commit-id: 21d1957
tydhot pushed a commit to tydhot/dubbo-go-pixiu that referenced this pull request Nov 10, 2021
Add gateway support for HTTPS

Former-commit-id: a5dd44b [formerly 21d1957]
Former-commit-id: b846617
bobtthp pushed a commit to bobtthp/dubbo-go-pixiu that referenced this pull request Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants