Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: command dependence use spf13/cobra instead #234

Merged
merged 8 commits into from
Aug 7, 2021

Conversation

MasterKenway
Copy link
Contributor

What this PR does:

refactor command dependence

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2021

Codecov Report

Merging #234 (3590d67) into develop (71a2d60) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #234      +/-   ##
===========================================
- Coverage    40.58%   40.50%   -0.08%     
===========================================
  Files           39       39              
  Lines         2267     2264       -3     
===========================================
- Hits           920      917       -3     
  Misses        1255     1255              
  Partials        92       92              
Impacted Files Coverage Δ
pkg/logger/logger.go 94.44% <100.00%> (-0.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71a2d60...3590d67. Read the comment docs.

cmd/pixiu/control.go Outdated Show resolved Hide resolved
Copy link
Contributor

@AlexStocks AlexStocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MasterKenway
Copy link
Contributor Author

MasterKenway commented Aug 5, 2021

readme needed to be updated Done

@AlexStocks AlexStocks merged commit ac2c232 into apache:develop Aug 7, 2021
mark4z pushed a commit that referenced this pull request Nov 7, 2021
refactor: command dependence use spf13/cobra instead
Former-commit-id: ac2c232
tydhot pushed a commit to tydhot/dubbo-go-pixiu that referenced this pull request Nov 10, 2021
refactor: command dependence use spf13/cobra instead
Former-commit-id: c407377 [formerly ac2c232]
Former-commit-id: eceaf07
bobtthp pushed a commit to bobtthp/dubbo-go-pixiu that referenced this pull request Dec 12, 2022
refactor: command dependence use spf13/cobra instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants