Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HttContext Reset Bug #254

Merged
merged 3 commits into from
Sep 24, 2021
Merged

Fix HttContext Reset Bug #254

merged 3 commits into from
Sep 24, 2021

Conversation

ztelur
Copy link
Contributor

@ztelur ztelur commented Sep 23, 2021

What this PR does:
fix the bug which http context reset function not clear data completely according to #252

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2021 •
edited
Loading

Codecov Report

Merging #254 (7d8d8ba) into develop (fb16f72) will decrease coverage by 0.10%.
The diff coverage is 11.11%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #254      +/-   ##
===========================================
- Coverage    39.61%   39.51%   -0.11%     
===========================================
  Files           50       50              
  Lines         2577     2584       +7     
===========================================
  Hits          1021     1021              
- Misses        1445     1452       +7     
  Partials       111      111
Impacted Files Coverage Δ
pkg/context/http/context.go 6.31% <11.11%> (-0.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb16f72...7d8d8ba. Read the comment docs.

mark4z
mark4z approved these changes Sep 24, 2021
View reviewed changes
Copy link
Member

@mark4z mark4z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@williamfeng323 williamfeng323 merged commit 3a15866 into apache:develop Sep 24, 2021
@ztelur ztelur added this to the v0.4.0 milestone Oct 20, 2021
mark4z pushed a commit that referenced this pull request Nov 7, 2021
@williamfeng323
Merge pull request #254 from ztelur/bugfix-reset
dc72864 
Fix HttContext Reset Bug 

Former-commit-id: 3a15866
tydhot pushed a commit to tydhot/dubbo-go-pixiu that referenced this pull request Nov 10, 2021
@williamfeng323
Merge pull request apache#254 from ztelur/bugfix-reset
c3fc8f5 
Fix HttContext Reset Bug 

Former-commit-id: dc72864 [formerly 3a15866]
Former-commit-id: e1c3452
bobtthp pushed a commit to bobtthp/dubbo-go-pixiu that referenced this pull request Dec 12, 2022
@williamfeng323
Merge pull request apache#254 from ztelur/bugfix-reset
f27aec7 
Fix HttContext Reset Bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexStocks AlexStocks AlexStocks approved these changes

@williamfeng323 williamfeng323 williamfeng323 approved these changes

@mark4z mark4z mark4z approved these changes

@xiaoliu10 xiaoliu10 Awaiting requested review from xiaoliu10

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ztelur @codecov-commenter @AlexStocks @williamfeng323 @mark4z