Feat: Pixiu connect with SpringCloud Server by nacos #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge origin develop
'get nacos client'
…o-go-pixiu into PhilYue-feature/springcloud
The rest code of get nacos client
Codecov Report
@@ Coverage Diff @@
## develop #255 +/- ##
===========================================
- Coverage 39.75% 39.56% -0.20%
===========================================
Files 50 50
Lines 2568 2626 +58
===========================================
+ Hits 1021 1039 +18
- Misses 1436 1475 +39
- Partials 111 112 +1
Continue to review full report at Codecov.
|
Feature/springcloud
import regroup
AlexStocks
reviewed
Oct 1, 2021
pkg/registry/zookeeper.go
Outdated
| @@ -18,6 +18,7 @@ | |||
| package registry | |||
|
|
|||
| import ( | |||
| "github.com/apache/dubbo-go-pixiu/pkg/model" | |||
There was a problem hiding this comment.
move it to the 3rd import block.
AlexStocks
reviewed
Oct 1, 2021
| } | ||
|
|
||
| ServiceDiscovery interface { | ||
| // 直接向远程注册中心查询所有服务实例 |
There was a problem hiding this comment.
translate it into english
AlexStocks
reviewed
Oct 1, 2021
pkg/adapter/springcloud/cloud.go
Outdated
| a.mutex.Lock() | ||
| defer a.mutex.Unlock() | ||
|
|
||
| var res []string |
There was a problem hiding this comment.
res := make([]string, 0, len(a.currentService))
AlexStocks
approved these changes
Oct 1, 2021
ztelur
approved these changes
Oct 2, 2021
xiaoliu10
approved these changes
Oct 2, 2021
mark4z
pushed a commit
that referenced
this pull request
Nov 7, 2021
Feat: Pixiu connect with SpringCloud Server by nacos Former-commit-id: 32a7ddf
bobtthp
pushed a commit
to bobtthp/dubbo-go-pixiu
that referenced
this pull request
Dec 12, 2022
Feat: Pixiu connect with SpringCloud Server by nacos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Pixiu connect with SpringCloud Server
Which issue(s) this PR fixes:
Fixes #
nope
Special notes for your reviewer:
nope
Does this PR introduce a user-facing change?:
nope