Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support https mutil certs #292

Merged
merged 12 commits into from
Nov 21, 2021
Merged

Support https mutil certs #292

merged 12 commits into from
Nov 21, 2021

Conversation

zhaoyadong00
Copy link
Contributor

What this PR does:
Support HTTPS multiple certificates.
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2021

Codecov Report

Merging #292 (248c479) into develop (c131ed5) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #292      +/-   ##
===========================================
- Coverage    33.99%   33.95%   -0.05%     
===========================================
  Files           61       61              
  Lines         3159     3163       +4     
===========================================
  Hits          1074     1074              
- Misses        1973     1977       +4     
  Partials       112      112              
Impacted Files Coverage Δ
pkg/model/base.go 0.00% <ø> (ø)
pkg/model/http.go 0.00% <ø> (ø)
pkg/server/listener.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c131ed5...248c479. Read the comment docs.

pkg/server/listener.go Outdated Show resolved Hide resolved
Copy link
Contributor

@MasterKenway MasterKenway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mark4z
Copy link
Member

mark4z commented Nov 12, 2021

Resolve conflicts then LGTM

Copy link
Member

@mark4z mark4z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve conflict pls

@mark4z mark4z merged commit 5bef485 into apache:develop Nov 21, 2021
bobtthp pushed a commit to bobtthp/dubbo-go-pixiu that referenced this pull request Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants