Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ftr: add default http to dubbo MappingParams #298

Merged
merged 11 commits into from
Dec 24, 2021

Conversation

cjphaha
Copy link
Member

@cjphaha cjphaha commented Nov 7, 2021

  • 如果 api_config 配置文件中设置了配置项,那么优先使用 api_config 中的配置,如果没有,使用默认的,最后生成一个总的获取原数据的规则
  • 默认规则目前是空的还没有写

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2021

Codecov Report

Merging #298 (183293f) into develop (300f0e9) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #298      +/-   ##
===========================================
- Coverage    36.80%   36.78%   -0.03%     
===========================================
  Files           54       54              
  Lines         3260     3262       +2     
===========================================
  Hits          1200     1200              
- Misses        1937     1938       +1     
- Partials       123      124       +1     
Impacted Files Coverage Δ
pkg/client/dubbo/dubbo.go 19.72% <0.00%> (-0.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 300f0e9...183293f. Read the comment docs.

@cjphaha cjphaha changed the title [WIP]: add default http to dubbo MappingParams Ftr: add default http to dubbo MappingParams Nov 21, 2021
@ztelur
Copy link
Contributor

ztelur commented Nov 26, 2021

plz fix ci problem

@ztelur
Copy link
Contributor

ztelur commented Dec 23, 2021

plz add a sample that uses default mapping params

@ztelur ztelur merged commit 04933a9 into apache:develop Dec 24, 2021
bobtthp pushed a commit to bobtthp/dubbo-go-pixiu that referenced this pull request Dec 12, 2022
* feat: add default MappingParams function

* docs: add license

* docs: add defaultMappingParams

* docs: dd a switch to use default mapping role

* fix: add Client.dubboProxyConfig nil check in MapParams func

Co-authored-by: Mark4z <36187602+mark4z@users.noreply.github.com>
Co-authored-by: Xin.Zh <dragoncharlie@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants