Ftr/triple #302
Ftr/triple #302
Conversation
LaurenceLiZhixin
commented
Nov 21, 2021
•
LaurenceLiZhixin
commented
- Ftr: http -> triple using dynamic API generation support
- Transfer dubbo-go server's ip:port from API to Client.
- Import formatted
- Nacos registry support
- HTTP random loadbalancer
- go version upgrate to 1.15
Codecov Report
@@ Coverage Diff @@
## develop #302 +/- ##
===========================================
- Coverage 33.93% 33.70% -0.23%
===========================================
Files 61 61
Lines 3165 3198 +33
===========================================
+ Hits 1074 1078 +4
- Misses 1979 2008 +29
Partials 112 112
Continue to review full report at Codecov.
|
| import ( | ||
| fc "github.com/dubbogo/dubbo-go-pixiu-filter/pkg/api/config" | ||
|
|
||
| etcdv3 "github.com/dubbogo/gost/database/kv/etcd/v3" | ||
|
|
||
| perrors "github.com/pkg/errors" | ||
|
|
||
| "go.etcd.io/etcd/api/v3/mvccpb" | ||
| ) |
There was a problem hiding this comment.
Those blank line kind of strange, isn't it ?
There was a problem hiding this comment.
Those blank line kind of strange, isn't it ?
+1
There was a problem hiding this comment.
Cai boss said follow the code formatting tool
| import ( | ||
| "github.com/dubbogo/dubbo-go-pixiu-filter/pkg/api/config" | ||
| "github.com/dubbogo/dubbo-go-pixiu-filter/pkg/router" | ||
|
|
||
| "github.com/pkg/errors" | ||
| ) | ||
|
|
||
| import ( | ||
| "github.com/apache/dubbo-go-pixiu/pkg/model" | ||
| "github.com/dubbogo/dubbo-go-pixiu-filter/pkg/api/config" | ||
| "github.com/dubbogo/dubbo-go-pixiu-filter/pkg/router" | ||
| ) | ||
|
|
There was a problem hiding this comment.
Imports here is not correct as well
|
@PhilYue As we discussed tonight, after server reflection is done, the |
|
我今天搞下nacos 支持，以及负载均衡，还有上述问题。import 块的问题都是按照 import-formatter 来规范的，这块是否还有问题？ |
|
@MasterKenway I guess this pr is able to be merged. |
