add http2 listener for grpc proxy #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…go-pixiu into feat-grpc-listener
Codecov Report
@@ Coverage Diff @@
## develop #315 +/- ##
===========================================
+ Coverage 38.89% 39.96% +1.06%
===========================================
Files 53 53
Lines 3121 3038 -83
===========================================
Hits 1214 1214
+ Misses 1778 1694 -84
- Partials 129 130 +1
Continue to review full report at Codecov.
|
|
Pls fix the problems from github action robot. |
|
pls fix the conflicts. |
# Conflicts: # pkg/listener/http/http_listener.go
AlexStocks
approved these changes
Dec 9, 2021
AlexStocks
reviewed
Dec 28, 2021
AlexStocks
reviewed
Dec 28, 2021
| - filter_chain_match: | ||
| domains: | ||
| - api.dubbo.com | ||
| - api.pixiu.com | ||
| filters: | ||
| - name: dgp.filter.httpconnectionmanager |
There was a problem hiding this comment.
as above, using its abbrevlation instead.
There was a problem hiding this comment.
following envoy http_connection_manager. hcm or gcm for grpcconnectionmanager make too much information lost
xiaoliu10
approved these changes
Jan 2, 2022
MasterKenway
approved these changes
Jan 3, 2022
bobtthp
pushed a commit
to bobtthp/dubbo-go-pixiu
that referenced
this pull request
Dec 12, 2022
* split listener service interface * split listener service interface * update * update * update * update * add integration test * add integration test * update * fix golangci-lint * update * fix reviewdog * fix reviewdog * fix reviewdog * update for comment * rename to NetworkFilterChain * update Co-authored-by: Mark4z <36187602+mark4z@users.noreply.github.com> Co-authored-by: Xin.Zh <dragoncharlie@foxmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
具体修改
1 将 Listener 提取出 interface，方便对不同协议扩展，目前有 HTTP 和 HTTP2两个struct
详见 pkg/listener/http2/http2_listener.go 分别进行不同的监听
2 实现 GrpcConnectionManager 这个 NetworkFilter，和旧的 HttpConnectionManager 是并列的。
将接收到的 HTTP2 request 进行拷贝，根据path选取cluster和endpoint，使用http2connection发送拷贝后的request给upstream grpc 服务器，然后将response的header，statuscode，body和tailor写回到给客户端的 response中
详见 pkg/common/grpc/manager.go
3 配置文件修改，将 protocolType 从 Address 提升到 Listener，将FilterChain从数组改变成单独结构体(P.S. 主要change来源这里，因为改了大量配置文件)
详见 pkg/filterchain/filter_chain.go