Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix nacos registry bug #389

Merged
merged 12 commits into from
Apr 17, 2022
Merged

Bugfix nacos registry bug #389

merged 12 commits into from
Apr 17, 2022

Conversation

ztelur
Copy link
Contributor

@ztelur ztelur commented Apr 4, 2022

What this PR does:

  • fix nacos registry bug
  • delete useless dubbo version code

@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2022 •
edited
Loading

Codecov Report

Merging #389 (8ec7706) into develop (9796805) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           develop     #389   +/-   ##
========================================
  Coverage    37.00%   37.00%           
========================================
  Files           55       55           
  Lines         3616     3616           
========================================
  Hits          1338     1338           
  Misses        2126     2126           
  Partials       152      152
Impacted Files Coverage Δ
pkg/client/dubbo/dubbo.go 19.46% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9796805...8ec7706. Read the comment docs.

mark4z
mark4z approved these changes Apr 4, 2022
View reviewed changes
pkg/client/dubbo/dubbo.go Show resolved Hide resolved
@AlexStocks AlexStocks merged commit afbdcce into apache:develop Apr 17, 2022
@PhilYue PhilYue added this to the v0.5.1 milestone Jul 9, 2022
bobtthp pushed a commit to bobtthp/dubbo-go-pixiu that referenced this pull request Dec 12, 2022
@AlexStocks
Merge pull request apache#389 from ztelur/bugfix-nacos-2
2d87534 
Bugfix nacos registry bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark4z mark4z mark4z approved these changes

@AlexStocks AlexStocks AlexStocks approved these changes

@PhilYue PhilYue PhilYue approved these changes

@baerwang baerwang baerwang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.5.1
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ztelur @codecov-commenter @AlexStocks @PhilYue @mark4z @baerwang