Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trace support for pixiu #394

Merged
merged 31 commits into from
Apr 25, 2022
Merged

trace support for pixiu #394

merged 31 commits into from
Apr 25, 2022

Conversation

maxingg
Copy link
Contributor

@maxingg maxingg commented Apr 8, 2022

Provide scalable trace support for pixiu, which developers can use to customize multiple exporters to collect data, and the flexibility to trace requests for multiple protocols. In addition, go version in .travis.yml has been upgraded to 1.17.:

Which issue(s) this PR fixes:

Fixes #376

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Yes. Trace configuration in conf.yaml includes exporter name and detailed configuration, sampling policy, etc. You can start the relevant container in docker-compose.yaml, and later encode it in the component to trace the request, or choose to customize the trace for a certain protocol.

@maxingg maxingg closed this Apr 8, 2022
@maxingg maxingg reopened this Apr 8, 2022
@ztelur ztelur requested review from ztelur and mark4z and removed request for ztelur April 8, 2022 05:37
pkg/server/otel.go Outdated Show resolved Hide resolved
pkg/server/otel.go Outdated Show resolved Hide resolved
pkg/tracing/api.go Outdated Show resolved Hide resolved
pkg/tracing/driver.go Outdated Show resolved Hide resolved
pkg/tracing/driver.go Outdated Show resolved Hide resolved
pkg/tracing/http.go Outdated Show resolved Hide resolved
pkg/tracing/http.go Outdated Show resolved Hide resolved
@maxingg
Copy link
Contributor Author

maxingg commented Apr 10, 2022

@AlexStocks 已更改

pkg/tracing/driver.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2022

Codecov Report

Merging #394 (f507cbc) into develop (d213568) will decrease coverage by 0.38%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop     #394      +/-   ##
===========================================
- Coverage    37.00%   36.61%   -0.39%     
===========================================
  Files           55       55              
  Lines         3616     3654      +38     
===========================================
  Hits          1338     1338              
- Misses        2126     2164      +38     
  Partials       152      152              
Impacted Files Coverage Δ
pkg/client/dubbo/dubbo.go 18.83% <0.00%> (-0.64%) ⬇️
pkg/common/http/manager.go 44.59% <0.00%> (ø)
pkg/server/otel.go 0.00% <0.00%> (ø)
pkg/server/pixiu_start.go 3.44% <0.00%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d213568...f507cbc. Read the comment docs.

pkg/server/otel.go Outdated Show resolved Hide resolved
@PhilYue
Copy link
Member

PhilYue commented Apr 21, 2022

@PhilYue

pkg/client/dubbo/dubbo.go Outdated Show resolved Hide resolved
pkg/server/otel.go Show resolved Hide resolved
pkg/tracing/driver.go Show resolved Hide resolved
pkg/tracing/driver.go Outdated Show resolved Hide resolved
convert dubbo vals to string, and add it into span
pkg/tracing/driver.go Outdated Show resolved Hide resolved
@AlexStocks AlexStocks merged commit 7717e84 into apache:develop Apr 25, 2022
@PhilYue PhilYue added this to the v0.5.1 milestone Jul 9, 2022
bobtthp pushed a commit to bobtthp/dubbo-go-pixiu that referenced this pull request Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase Pixiu observability
5 participants