Feat: SpringCloud subscribe strategy and Adapter add enabled config #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #425 +/- ##
===========================================
+ Coverage 37.58% 37.64% +0.06%
===========================================
Files 55 55
Lines 3720 3743 +23
===========================================
+ Hits 1398 1409 +11
- Misses 2166 2176 +10
- Partials 156 158 +2
Continue to review full report at Codecov.
|
|
Good job |
AlexStocks
approved these changes
May 20, 2022
mark4z
approved these changes
May 21, 2022
| Config map[string]interface{} `yaml:"config" json:"config" mapstructure:"config"` // Config adapter config | ||
| ID string `yaml:"id" json:"id"` | ||
| Name string `yaml:"name" json:"name"` // Name the adapter unique name | ||
| Enabled string `yaml:"enabled" json:"enabled" default:"true"` |
There was a problem hiding this comment.
启动时，加载配置时 默认值函数（default.Set）会吧自定义的值覆盖了
ztelur
reviewed
May 21, 2022
ztelur
approved these changes
May 22, 2022
bobtthp
pushed a commit
to bobtthp/dubbo-go-pixiu
that referenced
this pull request
Dec 12, 2022
Feat: SpringCloud subscribe strategy and Adapter add enabled config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #
#410
Special notes for your reviewer:
Does this PR introduce a user-facing change?: