Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 508 #510

Merged
merged 1 commit into from
Oct 30, 2022
Merged

Conversation

nicktming
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:

Fixes #508

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

Codecov Report

Merging #510 (cd5ccb8) into develop (8ef6126) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop     #510      +/-   ##
===========================================
+ Coverage    54.72%   54.73%   +0.01%     
===========================================
  Files          664      664              
  Lines        77745    77746       +1     
===========================================
+ Hits         42544    42553       +9     
+ Misses       31562    31549      -13     
- Partials      3639     3644       +5     
Impacted Files Coverage Δ
pixiu/pkg/client/dubbo/dubbo.go 21.60% <0.00%> (+3.59%) ⬆️
pkg/hbone/util.go 82.85% <0.00%> (-11.43%) ⬇️
pkg/envoy/admin.go 50.00% <0.00%> (-9.68%) ⬇️
pilot/pkg/networking/grpcgen/lds.go 90.51% <0.00%> (-1.73%) ⬇️
pkg/envoy/instance.go 76.27% <0.00%> (-1.70%) ⬇️
pkg/istio-agent/xds_proxy_delta.go 51.29% <0.00%> (-0.52%) ⬇️
security/pkg/credentialfetcher/fetcher.go 40.00% <0.00%> (ø)
.../pkg/serviceregistry/kube/controller/controller.go 72.68% <0.00%> (+0.15%) ⬆️
pilot/pkg/bootstrap/server.go 53.56% <0.00%> (+0.75%) ⬆️
pkg/istio-agent/xds_proxy.go 60.52% <0.00%> (+0.86%) ⬆️
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@mark4z mark4z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexStocks AlexStocks merged commit b562502 into apache:develop Oct 30, 2022
bobtthp pushed a commit to bobtthp/dubbo-go-pixiu that referenced this pull request Dec 12, 2022
@mark4z mark4z added this to the v1.0.0 milestone Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dubboproxy apply nil pointer
4 participants