Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize timeout statusCode #521

Merged
merged 3 commits into from
Jan 4, 2023
Merged

Conversation

CSWYF3634076
Copy link
Contributor

@CSWYF3634076 CSWYF3634076 commented Nov 13, 2022

What this PR does:
timeout test bug:https://dubbogoproxy.yuque.com/dubbogoproxy/vld1hq/rfr2mf#gIX74
optimize timeout statusCode
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
dubbo 超时返回内容,加入TODO
Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2022

Codecov Report

Merging #521 (151f52a) into develop (84affca) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop     #521      +/-   ##
===========================================
+ Coverage    54.68%   54.70%   +0.01%     
===========================================
  Files          666      666              
  Lines        77865    77868       +3     
===========================================
+ Hits         42577    42594      +17     
+ Misses       31653    31640      -13     
+ Partials      3635     3634       -1     
Impacted Files Coverage Δ
pixiu/pkg/client/dubbo/dubbo.go 21.60% <0.00%> (ø)
pixiu/pkg/client/http/http.go 40.69% <0.00%> (-1.48%) ⬇️
pkg/envoy/admin.go 50.00% <0.00%> (-9.68%) ⬇️
pilot/pkg/config/memory/monitor.go 71.79% <0.00%> (-7.70%) ⬇️
pilot/pkg/model/addressmap.go 63.23% <0.00%> (-4.42%) ⬇️
pkg/envoy/instance.go 76.27% <0.00%> (-1.70%) ⬇️
pkg/istio-agent/xds_proxy.go 60.52% <0.00%> (-1.52%) ⬇️
pilot/pkg/xds/discovery.go 84.93% <0.00%> (-0.97%) ⬇️
...g/serviceregistry/kube/controller/endpointslice.go 73.44% <0.00%> (-0.69%) ⬇️
pilot/pkg/bootstrap/server.go 53.11% <0.00%> (-0.61%) ⬇️
... and 524 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Dec 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@CSWYF3634076 CSWYF3634076 changed the title [WIP] Optimize timeout statusCode Optimize timeout statusCode Dec 4, 2022
Copy link
Member

@mark4z mark4z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexStocks AlexStocks merged commit 79c4c54 into apache:develop Jan 4, 2023
@mark4z mark4z added this to the v1.0.0 milestone Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants