Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GracefulShutdown Signal For Windows #522

Merged
merged 3 commits into from
Nov 21, 2022
Merged

Conversation

A-Wanderer
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2022

Codecov Report

Merging #522 (c8eee75) into develop (84affca) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #522   +/-   ##
========================================
  Coverage    54.68%   54.68%           
========================================
  Files          666      666           
  Lines        77865    77865           
========================================
+ Hits         42577    42580    +3     
+ Misses       31653    31642   -11     
- Partials      3635     3643    +8     
Impacted Files Coverage Δ
pilot/pkg/config/memory/monitor.go 71.79% <0.00%> (-7.70%) ⬇️
pilot/pkg/model/addressmap.go 63.23% <0.00%> (-4.42%) ⬇️
...try/kube/controller/autoserviceexportcontroller.go 61.11% <0.00%> (-4.17%) ⬇️
pkg/config/mesh/kubemesh/watcher.go 67.21% <0.00%> (-3.28%) ⬇️
pilot/pkg/xds/deltaadstest.go 58.51% <0.00%> (-1.49%) ⬇️
pkg/istio-agent/xds_proxy.go 60.95% <0.00%> (-1.09%) ⬇️
pilot/pkg/bootstrap/server.go 52.80% <0.00%> (-0.92%) ⬇️
.../pkg/serviceregistry/kube/controller/controller.go 72.68% <0.00%> (+0.15%) ⬆️
pilot/pkg/model/service.go 45.70% <0.00%> (+0.90%) ⬆️
pkg/istio-agent/agent.go 56.73% <0.00%> (+1.68%) ⬆️
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mark4z
Copy link
Member

mark4z commented Nov 18, 2022

image
on win10

@sonarcloud
Copy link

sonarcloud bot commented Nov 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mark4z mark4z merged commit 7c57367 into apache:develop Nov 21, 2022
bobtthp pushed a commit to bobtthp/dubbo-go-pixiu that referenced this pull request Dec 12, 2022
* Add GracefulShutdown Signal

* fix format

* update shutdown signal & close wasm for windows

Co-authored-by: mark4z <mark4z@apache.org>
AlexStocks pushed a commit that referenced this pull request Mar 24, 2023
* snp init

* istio build tools

* istio build tools

* license

* license

* add snp resource

* add snp resource

* snp push_context.go

* fix deploy pilot

* fix make gen

* rollback delete dir

* fix mac gocache permission

* snp push_context.go

* open dev & fix snp

* open dev

* snp register

* snp register

* snp register

* snp register

* snp register debounce

* Add GracefulShutdown Signal For Windows (#522)

* Add GracefulShutdown Signal

* fix format

* update shutdown signal & close wasm for windows

Co-authored-by: mark4z <mark4z@apache.org>

* add and modify  nacos config arguments (#524)

* Update bootstrap.go

* Update config_load.go

* add snp clusterrole

* add snp clusterrole

* imports format

* imports format

* update dingding group img

* replace operator-api

* fmt

* rm Dockerfile

* do not start debounce on snp server not init.

* refactor func tryRegister

* refactor func debounce

* docs for debounce

* snp support multi namespace

* snp support multi namespace

* snp support multi namespace

* snp support multi namespace

---------

Co-authored-by: bobtthp <bobtthp@bob-Mac-mini.local>
Co-authored-by: bobtthp <gzqtianc@gmail.com>
Co-authored-by: Nanno <64241032+A-Wanderer@users.noreply.github.com>
Co-authored-by: happyjack <zgq25302111@126.com>
@mark4z mark4z added this to the v1.0.0 milestone Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants