Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore:use wasm filter build tags add wasm #567

Merged
merged 1 commit into from
Jun 18, 2023

Conversation

baerwang
Copy link
Member

@baerwang baerwang commented Jun 6, 2023

What this PR does:

Which issue(s) this PR fixes:

Fixes #566

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2023

Codecov Report

Merging #567 (f056f11) into develop (76cf95c) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head f056f11 differs from pull request most recent head c88f501. Consider uploading reports for the commit c88f501 to get more accurate results

@@             Coverage Diff             @@
##           develop     #567      +/-   ##
===========================================
+ Coverage    54.78%   54.81%   +0.02%     
===========================================
  Files          669      669              
  Lines        78297    78297              
===========================================
+ Hits         42898    42915      +17     
+ Misses       31734    31730       -4     
+ Partials      3665     3652      -13     

see 15 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlexStocks
Copy link
Contributor

AlexStocks commented Jun 6, 2023

关于 wasm,请在 readme 里面也说下吧。给用户说明白,要启用 wasm,需要怎么怎么做

@baerwang
Copy link
Member Author

baerwang commented Jun 7, 2023

关于 wasm,请在 readme 里面也说下吧。给用户说明白,要启用 wasm,需要怎么怎么做

done

Copy link
Member

@mark4z mark4z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
* limitations under the License.
*/

package pluginregistry
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pluginregistry 改名为 plugin_registry?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个改不了,要改的话,ci也要同步改,改动比较大

@sonarcloud
Copy link

sonarcloud bot commented Jun 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AlexStocks AlexStocks merged commit c0bf34e into apache:develop Jun 18, 2023
13 checks passed
@mark4z mark4z added this to the v1.0.0 milestone Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable wasm by default
4 participants