Feature/http 2 http param mapping #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamfeng323
force-pushed
the
feature/http-2-http-param-mapping
branch
from
63555c1
to
15dc11f
Compare
Codecov Report
@@ Coverage Diff @@
## develop #57 +/- ##
===========================================
- Coverage 45.74% 43.71% -2.04%
===========================================
Files 21 28 +7
Lines 929 1217 +288
===========================================
+ Hits 425 532 +107
- Misses 454 613 +159
- Partials 50 72 +22
Continue to review full report at Codecov.
|
williamfeng323
force-pushed
the
feature/http-2-http-param-mapping
branch
from
15dc11f
to
327372f
Compare
williamfeng323
force-pushed
the
feature/http-2-http-param-mapping
branch
from
327372f
to
a678ce7
Compare
cityiron
reviewed
Nov 17, 2020
pkg/client/dubbo/mapper.go
Outdated
| @@ -30,19 +30,30 @@ import ( | |||
| ) | |||
|
|
|||
| import ( | |||
| "encoding/json" | |||
pkg/client/dubbo/mapper.go
Outdated
| return nil, nil | ||
| type uriMapper struct{} | ||
|
|
||
| func (um uriMapper) Map(mp config.MappingParam, c client.Request, target interface{}) error { |
There was a problem hiding this comment.
Map is public, add // nolint?
pkg/client/http/mapper.go
Outdated
|
|
||
| type bodyMapper struct{} | ||
|
|
||
| func (bm bodyMapper) Map(mp config.MappingParam, c client.Request, rawTarget interface{}) error { |
pkg/router/api.go
Outdated
| import ( | ||
| "github.com/dubbogo/dubbo-go-proxy/pkg/config" | ||
| "strings" |
There was a problem hiding this comment.
move to first import part
pkg/router/api_test.go
Outdated
| package router | ||
|
|
||
| import ( | ||
| "github.com/dubbogo/dubbo-go-proxy/pkg/config" |
pkg/router/route.go
Outdated
| @@ -30,6 +30,7 @@ import ( | |||
| import ( | |||
| "github.com/dubbogo/dubbo-go-proxy/pkg/common/constant" | |||
| "github.com/dubbogo/dubbo-go-proxy/pkg/config" | |||
| "net/url" | |||
| r.Header = req.IngressRequest.Header.Clone() | ||
| queryValues, err := url.ParseQuery(req.IngressRequest.URL.RawQuery) | ||
| if err != nil { | ||
| return nil, errors.New("Retrieve request query parameters failed") |
There was a problem hiding this comment.
I think we need create err together errors.New() in next step.
yqxu
approved these changes
Nov 17, 2020
williamfeng323
force-pushed
the
feature/http-2-http-param-mapping
branch
from
d4d4984
to
aa8f29d
Compare
cityiron
approved these changes
Nov 18, 2020
pkg/client/dubbo/dubbo.go
Outdated
| @@ -162,22 +154,22 @@ func (dc *Client) Call(req *client.Request) (res interface{}, err error) { | |||
| return rst, nil | |||
| } | |||
|
|
|||
| // MappingParams param mapping to api. | |||
| func (dc *Client) MappingParams(req *client.Request) ([]string, []interface{}, error) { | |||
| // MapParams param mapping to api. | |||
pkg/client/dubbo/mapper.go
Outdated
| type queryStringsMapper struct{} | ||
|
|
||
| // nolint | ||
| func (qm queryStringsMapper) Map(mp config.MappingParam, c client.Request, target interface{}) error { |
There was a problem hiding this comment.
why isn't the caller pointer?
There was a problem hiding this comment.
originally, I don't hope to modify anything inside the client.Request, but since I have to add back the body after mapping the request body, I think pointer might be better now.
zhangshen023
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #54 #56
Special notes for your reviewer:
Does this PR introduce a user-facing change?: