Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify loadbalance strategy on dubbo proxy #613

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Conversation

mark4z
Copy link
Member

@mark4z mark4z commented Feb 5, 2024

What this PR does:
Now we can specify loadbalance strategy on dubbo proxy like this:

                  - name: dgp.filter.http.dubboproxy
                    config:
                      dubboProxyConfig:
                        auto_resolve: true
                        load_balance: consistenthashing
                        registries:
                          "zookeeper":
                            protocol: "zookeeper"

And now there is a few options:

  1. consistenthashing
  2. leastactive
  3. random
  4. ringhash
  5. roundrobin

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@mark4z mark4z changed the base branch from develop to 1.0.0 February 5, 2024 08:44
Copy link

sonarcloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mark4z mark4z changed the base branch from 1.0.0 to develop February 5, 2024 08:53
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7c949f6) 54.68% compared to head (5088e89) 54.72%.
Report is 1 commits behind head on develop.

❗ Current head 5088e89 differs from pull request most recent head 86ede57. Consider uploading reports for the commit 86ede57 to get more accurate results

Files Patch % Lines
pixiu/pkg/client/dubbo/dubbo.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #613      +/-   ##
===========================================
+ Coverage    54.68%   54.72%   +0.03%     
===========================================
  Files          671      671              
  Lines        78657    78658       +1     
===========================================
+ Hits         43013    43045      +32     
+ Misses       31977    31949      -28     
+ Partials      3667     3664       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mark4z mark4z merged commit dd6630e into apache:develop Feb 5, 2024
12 checks passed
mark4z added a commit that referenced this pull request Feb 5, 2024
* 1.0.0 (#595)

* V1.0.0 Changes (#588)

* [feature] cors support options request (#591)

* V1.0.0 Changes

* [feature] cors support options request

* 1.0.0 (#602)

* V1.0.0 Changes (#588)

* [feature] cors support options request (#591)

* V1.0.0 Changes

* [feature] cors support options request

* Move Pixiu cmd files in /cmd/pixiu to pkg/cmd (#596)

* remove unused types JTypeMapper check & support default types. (#597)

* build(deps): bump jinja2 in /samples/bookinfo/src/productpage (#607)

Bumps [jinja2](https://github.com/pallets/jinja) from 2.11.3 to 3.1.3.
- [Release notes](https://github.com/pallets/jinja/releases)
- [Changelog](https://github.com/pallets/jinja/blob/main/CHANGES.rst)
- [Commits](pallets/jinja@2.11.3...3.1.3)

---
updated-dependencies:
- dependency-name: jinja2
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump github.com/lestrrat-go/jwx from 1.2.26 to 1.2.27 (#609)

Bumps [github.com/lestrrat-go/jwx](https://github.com/lestrrat-go/jwx) from 1.2.26 to 1.2.27.
- [Release notes](https://github.com/lestrrat-go/jwx/releases)
- [Changelog](https://github.com/lestrrat-go/jwx/blob/v1.2.27/Changes)
- [Commits](lestrrat-go/jwx@v1.2.26...v1.2.27)

---
updated-dependencies:
- dependency-name: github.com/lestrrat-go/jwx
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump github.com/lestrrat-go/jwx from 1.2.27 to 1.2.28 (#610)

Bumps [github.com/lestrrat-go/jwx](https://github.com/lestrrat-go/jwx) from 1.2.27 to 1.2.28.
- [Release notes](https://github.com/lestrrat-go/jwx/releases)
- [Changelog](https://github.com/lestrrat-go/jwx/blob/v1.2.28/Changes)
- [Commits](lestrrat-go/jwx@v1.2.27...v1.2.28)

---
updated-dependencies:
- dependency-name: github.com/lestrrat-go/jwx
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* 1.0.0 (#614)

* V1.0.0 Changes (#588)

* [feature] cors support options request (#591)

* V1.0.0 Changes

* [feature] cors support options request

* Move Pixiu cmd files in /cmd/pixiu to pkg/cmd (#596)

* remove unused types JTypeMapper check & support default types. (#597)

* specify loadbalance strategy on dubbo proxy (#613)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@mark4z mark4z added this to the v1.0.1 milestone May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants