Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add registry protocol config #90

Merged
merged 2 commits into from
Dec 28, 2020
Merged

add registry protocol config #90

merged 2 commits into from
Dec 28, 2020

Conversation

xiaoliu10
Copy link
Contributor

What this PR does:
when i have two zk registry , i can't use it , beacuse there is a map for registry config and registry type is key
this pr will fix it

Which issue(s) this PR fixes:

Fixes #89

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@xiaoliu10 xiaoliu10 self-assigned this Dec 23, 2020
@codecov-io
Copy link

codecov-io commented Dec 23, 2020

Codecov Report

Merging #90 (6dd28cc) into develop (a56c18c) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #90   +/-   ##
========================================
  Coverage    42.01%   42.01%           
========================================
  Files           33       33           
  Lines         1409     1409           
========================================
  Hits           592      592           
  Misses         733      733           
  Partials        84       84           
Impacted Files Coverage Δ
pkg/client/dubbo/dubbo.go 22.64% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a56c18c...6dd28cc. Read the comment docs.

@cityiron cityiron merged commit a39dc64 into apache:develop Dec 28, 2020
@cityiron cityiron added this to the v0.1.0 milestone Jan 8, 2021
mark4z pushed a commit that referenced this pull request Nov 7, 2021
add registry protocol config

Former-commit-id: b7d31b4 [formerly a39dc64]
Former-commit-id: b7d31b4
Former-commit-id: ad5db13
tydhot pushed a commit to tydhot/dubbo-go-pixiu that referenced this pull request Nov 10, 2021
add registry protocol config

Former-commit-id: e86d50b [formerly b7d31b4 [formerly a39dc64]]
Former-commit-id: 29f0d47 [formerly b7d31b4]
Former-commit-id: 0d1f9a6 [formerly ad5db13]
Former-commit-id: 481eda5
bobtthp pushed a commit to bobtthp/dubbo-go-pixiu that referenced this pull request Dec 12, 2022
add registry protocol config

Former-commit-id: a39dc64
Former-commit-id: b7d31b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

when i have two zk registry, i can't configure it
5 participants