Fix: add zh and en triple readme and some features #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
LaurenceLiZhixin
commented
Oct 2, 2021
•
LaurenceLiZhixin
commented
- Triple zk and en README
- New config api samples
- registry -> registries
justxuewei
reviewed
Oct 2, 2021
rpc/triple/README.md
Outdated
| protocol: myProtocol # user defined protocol key，as above myProtocol defined | ||
| interface: org.apache.dubbogo.MyProvider # user defined interface name | ||
| # serialization: hessian2 # serialization that can be choosed：pb/hessian2/custome | ||
| # pb serialization by default |
There was a problem hiding this comment.
Tab(\t) shouldn't be used in yaml, please consider replacing tab with 2 spaces.
There was a problem hiding this comment.
Thanks for your suggestions, Done! @xueweiniu
zhaoyunxing92
approved these changes
Oct 2, 2021
LaurenceLiZhixin
changed the title
cjphaha
approved these changes
Oct 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.