[feat]: add new samples java interop - service discovery #727
Conversation
|
|
||
| import ( | ||
| "context" | ||
| // "time" |
There was a problem hiding this comment.
If you do not need these packages, pls remove them
| "dubbo.apache.org/dubbo-go/v3" | ||
| // "dubbo.apache.org/dubbo-go/v3/config" | ||
|
|
||
| _ "dubbo.apache.org/dubbo-go/v3/client" |
There was a problem hiding this comment.
Why is it implicitly imported here?
| registry.WithAddress("127.0.0.1:8848"), | ||
| ), | ||
|
|
||
| // dubbo.WithMetadataReport(metadata.WithMetadata())), |
| logger.Error(err) | ||
| } | ||
| logger.Infof("Greet response: %s", resp) | ||
| // select {} |
| "context" | ||
|
|
||
| "dubbo.apache.org/dubbo-go/v3" | ||
| // "dubbo.apache.org/dubbo-go/v3/config" |
| return resp, nil | ||
| } | ||
|
|
||
| func (s *GreetTripleServer) MethodMapper() map[string]string { |
There was a problem hiding this comment.
If we do not add MethodMapper method, Java client could not invoke the Go Server?
There was a problem hiding this comment.
sorry, it turn out that java client can still invoke the go server. i made a mistake. The reason why i add MethodMapper is https://cn.dubbo.apache.org/zh-cn/overview/mannual/golang-sdk/tutorial/develop/interflow/call_java/#22-java-client---go-server
and i referenced the wrong part (Part2 Hessian2 serialize)
|
For dubbo java part, cc @FoghostCn . |
|
Btw, I'd like to suggest you formatting your java code, e.g. google-java-format. What formatting tool is used in Dubbo? /cc @chickenlj |
|
i will fix it soon |
|
The generated code does not need to be submitted, just configure the maven idl plugin |
| import java.util.concurrent.CountDownLatch; | ||
|
|
||
| public class Main { | ||
| private static GreetService greetService; |
There was a problem hiding this comment.
pls make greetService as method private
| <modelVersion>4.0.0</modelVersion> | ||
|
|
||
| <groupId>org.apache.dubbo</groupId> | ||
| <artifactId>samples</artifactId> |
There was a problem hiding this comment.
Please use a more meaningful module name
| <modelVersion>4.0.0</modelVersion> | ||
|
|
||
| <groupId>org.apache.dubbo</groupId> | ||
| <artifactId>samples</artifactId> |
There was a problem hiding this comment.
Please use a more meaningful module name
|
ok, i will fix it soon |
spotless plugin is used in dubbo-java |
i finish the samples with java-go interop service discovery both service level and interface level
related issue: #698