Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove zk test in 1.5 #1363

Merged
merged 1 commit into from Aug 7, 2021
Merged

remove zk test in 1.5 #1363

merged 1 commit into from Aug 7, 2021

Conversation

tydhot
Copy link
Member

@tydhot tydhot commented Aug 3, 2021

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

Codecov Report

Merging #1363 (4b05547) into 1.5 (467c867) will decrease coverage by 2.55%.
The diff coverage is 63.02%.

❗ Current head 4b05547 differs from pull request most recent head cffc514. Consider uploading reports for the commit cffc514 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              1.5    #1363      +/-   ##
==========================================
- Coverage   58.07%   55.52%   -2.56%     
==========================================
  Files         275      276       +1     
  Lines       13381    15942    +2561     
==========================================
+ Hits         7771     8851    +1080     
- Misses       4650     6152    +1502     
+ Partials      960      939      -21     
Impacted Files Coverage Δ
config/config_loader.go 43.40% <0.00%> (+4.56%) ⬆️
config/provider_config.go 62.06% <0.00%> (+7.52%) ⬆️
config/reference_config.go 80.00% <0.00%> (-1.67%) ⬇️
registry/zookeeper/listener.go 26.58% <0.00%> (-42.65%) ⬇️
remoting/zookeeper/listener.go 0.00% <0.00%> (-41.29%) ⬇️
config/config_center_config.go 66.21% <33.33%> (+2.03%) ⬆️
registry/directory/directory.go 77.89% <58.33%> (+2.14%) ⬆️
protocol/dubbo/dubbo_invoker.go 70.29% <60.00%> (+0.97%) ⬆️
filter/filter_impl/generic_filter.go 62.50% <65.38%> (-8.72%) ⬇️
protocol/grpc/server.go 77.14% <66.66%> (+3.80%) ⬆️
... and 291 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e781ec...cffc514. Read the comment docs.

@AlexStocks AlexStocks merged commit 76b78e5 into apache:1.5 Aug 7, 2021
@zhaoyunxing92 zhaoyunxing92 added this to the v1.5.7 milestone Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants