Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(getty): upgrade getty version to 1.4.5 for dubbo-go 1.5 #1378

Merged
merged 3 commits into from Aug 20, 2021

Conversation

Mulavar
Copy link
Member

@Mulavar Mulavar commented Aug 14, 2021

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2021

Codecov Report

Merging #1378 (0e705e5) into 1.5 (467c867) will decrease coverage by 2.55%.
The diff coverage is 61.76%.

❗ Current head 0e705e5 differs from pull request most recent head cda10ba. Consider uploading reports for the commit cda10ba to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              1.5    #1378      +/-   ##
==========================================
- Coverage   58.07%   55.52%   -2.56%     
==========================================
  Files         275      276       +1     
  Lines       13381    15941    +2560     
==========================================
+ Hits         7771     8851    +1080     
- Misses       4650     6154    +1504     
+ Partials      960      936      -24     
Impacted Files Coverage Δ
config/config_loader.go 43.40% <0.00%> (+4.56%) ⬆️
config/provider_config.go 62.06% <0.00%> (+7.52%) ⬆️
config/reference_config.go 80.00% <0.00%> (-1.67%) ⬇️
config_center/nacos/facade.go 71.87% <0.00%> (-17.79%) ⬇️
registry/consul/registry.go 51.64% <0.00%> (+2.31%) ⬆️
...gistry/event/protocol_ports_metadata_customizer.go 65.78% <ø> (+6.41%) ⬆️
registry/kubernetes/registry.go 64.15% <0.00%> (+13.03%) ⬆️
registry/zookeeper/listener.go 26.58% <0.00%> (-42.65%) ⬇️
remoting/etcdv3/client.go 55.69% <0.00%> (+2.69%) ⬆️
remoting/etcdv3/facade.go 0.00% <0.00%> (ø)
... and 308 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3d0ae9...cda10ba. Read the comment docs.

@Mulavar Mulavar changed the title [WIP]feat(getty): upgrade getty version to 1.4.5 for dubbo-go 1.5 feat(getty): upgrade getty version to 1.4.5 for dubbo-go 1.5 Aug 18, 2021
remoting/getty/listener.go Outdated Show resolved Hide resolved
@AlexStocks AlexStocks merged commit 81c2e23 into apache:1.5 Aug 20, 2021
@zhaoyunxing92 zhaoyunxing92 added this to the v1.5.7 milestone Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants