Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dynamic route config #1519

Merged
merged 6 commits into from Oct 25, 2021
Merged

Conversation

Mulavar
Copy link
Member

@Mulavar Mulavar commented Oct 14, 2021

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2021

Codecov Report

Merging #1519 (b3a07b2) into 3.0 (4b1746f) will increase coverage by 0.10%.
The diff coverage is 46.66%.

❗ Current head b3a07b2 differs from pull request most recent head 26de707. Consider uploading reports for the commit 26de707 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #1519      +/-   ##
==========================================
+ Coverage   41.86%   41.96%   +0.10%     
==========================================
  Files         259      258       -1     
  Lines       15109    15111       +2     
==========================================
+ Hits         6325     6341      +16     
+ Misses       8049     8032      -17     
- Partials      735      738       +3     
Impacted Files Coverage Δ
cluster/directory/static/directory.go 66.66% <0.00%> (+1.66%) ⬆️
common/extension/router_factory.go 0.00% <ø> (ø)
config/config_loader.go 13.23% <ø> (ø)
config/reference_config.go 0.00% <ø> (ø)
config/uniform_router_config.go 0.00% <ø> (ø)
config_center/mock_dynamic_config.go 0.00% <0.00%> (ø)
registry/nacos/service_discovery.go 1.07% <0.00%> (-0.02%) ⬇️
registry/service_instance.go 0.00% <ø> (ø)
remoting/getty/listener.go 27.05% <0.00%> (ø)
remoting/zookeeper/listener.go 0.00% <0.00%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b1746f...26de707. Read the comment docs.

@Mulavar Mulavar force-pushed the feat/dynamic-route-cfg branch 2 times, most recently from 32f6ca1 to 99a63e1 Compare October 15, 2021 11:00
@Mulavar Mulavar force-pushed the feat/dynamic-route-cfg branch 2 times, most recently from 3e48334 to 902c085 Compare October 17, 2021 15:25
2. add base64Enable flag to zookeeperDynamicConfiguration
@LaurenceLiZhixin LaurenceLiZhixin changed the title [WIP]add dynamic route config add dynamic route config Oct 22, 2021
@LaurenceLiZhixin LaurenceLiZhixin merged commit e551945 into apache:3.0 Oct 25, 2021
justxuewei pushed a commit to justxuewei/dubbo-go that referenced this pull request Oct 28, 2021
* remove struct DubboRouterRule which is useless

* remove some error which is useless

* rename DubboServiceRouterItem to DubboRouteDetail

* 1. add zk mesh route dynamic configuration listener
2. add base64Enable flag to zookeeperDynamicConfiguration

* rename Router to Routers

* Revert "rename Router to Routers"

This reverts commit dd0867d

Co-authored-by: dongjianhui03 <dongjianhui03@meituan.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants