Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add metrics basic support #1540

Merged
merged 4 commits into from
Oct 27, 2021
Merged

fix: add metrics basic support #1540

merged 4 commits into from
Oct 27, 2021

Conversation

LaurenceLiZhixin
Copy link
Contributor

@LaurenceLiZhixin LaurenceLiZhixin commented Oct 26, 2021

  • 增加了 Metrics 配置字段
  • 增加了默认 Metrics 接口支持
  • 默认启动9090端口数据上报
  • protocolIDs -> protocol-ids | registryIDs -> registry-ids

后需要做的;

  • push gateway 支持
  • invocation 的 metrics 默认收集:tps/rt + 必要的label,删除已有意义不大的直方图指标

Fixes #1541

@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2021

Codecov Report

Merging #1540 (500342a) into 3.0 (a45fd29) will increase coverage by 0.20%.
The diff coverage is 46.15%.

❗ Current head 500342a differs from pull request most recent head 4d4fb6e. Consider uploading reports for the commit 4d4fb6e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #1540      +/-   ##
==========================================
+ Coverage   41.75%   41.95%   +0.20%     
==========================================
  Files         258      258              
  Lines       15111    15121      +10     
==========================================
+ Hits         6309     6344      +35     
+ Misses       8068     8037      -31     
- Partials      734      740       +6     
Impacted Files Coverage Δ
config/consumer_config.go 24.74% <ø> (ø)
config/provider_config.go 24.65% <ø> (ø)
config/reference_config.go 0.00% <ø> (ø)
config/router_config.go 5.26% <ø> (ø)
config/service_config.go 9.39% <ø> (ø)
metrics/prometheus/reporter.go 40.55% <34.14%> (-1.02%) ⬇️
config/metric_config.go 66.66% <60.00%> (+45.23%) ⬆️
common/extension/metrics.go 71.42% <100.00%> (ø)
filter/metrics/filter.go 85.00% <100.00%> (-15.00%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a45fd29...4d4fb6e. Read the comment docs.

@LaurenceLiZhixin
Copy link
Contributor Author

CI may passed after pr: https://github.com/apache/dubbo-go-samples/pull/281/files merged

Copy link
Member

@justxuewei justxuewei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justxuewei justxuewei merged commit c378031 into 3.0 Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants