Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support multi registry address #1671

Merged
merged 1 commit into from Dec 18, 2021
Merged

support multi registry address #1671

merged 1 commit into from Dec 18, 2021

Conversation

xfstart07
Copy link
Contributor

What this PR does:

支持多地址

zhaoyunxing92
zhaoyunxing92 reviewed Dec 16, 2021
View reviewed changes
Copy link
Contributor

@zhaoyunxing92 zhaoyunxing92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个有使用场景吗

@xfstart07
Copy link
Contributor Author

centerconfig (https://github.com/apache/dubbo-go-samples/blob/master/configcenter/zookeeper/go-server/conf/dubbogo.yml#L2) 配置多个就会报错

@justxuewei
Copy link
Member

centerconfig (https://github.com/apache/dubbo-go-samples/blob/master/configcenter/zookeeper/go-server/conf/dubbogo.yml#L2) 配置多个就会报错

什么是“配置多个就会报错”？能麻烦给个例子吗？

@justxuewei justxuewei mentioned this pull request Dec 17, 2021
Merged
@LaurenceLiZhixin
Copy link
Contributor

centerconfig (https://github.com/apache/dubbo-go-samples/blob/master/configcenter/zookeeper/go-server/conf/dubbogo.yml#L2) 配置多个就会报错

这个是3.0 的sample，为啥会改到1.5 的代码上？

@AlexStocks AlexStocks merged commit 060e273 into apache:1.5 Dec 18, 2021
@AlexStocks AlexStocks changed the title support multi address support multi registry address Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexStocks AlexStocks AlexStocks approved these changes

@zhaoyunxing92 zhaoyunxing92 zhaoyunxing92 approved these changes

@Mulavar Mulavar Mulavar approved these changes

@cjphaha cjphaha cjphaha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@xfstart07 @justxuewei @LaurenceLiZhixin @AlexStocks @zhaoyunxing92 @Mulavar @cjphaha