Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove HEADER_LENGTH in decode because of discard #1831

Merged
merged 1 commit into from Apr 16, 2022

Conversation

Lvnszn
Copy link
Contributor

@Lvnszn Lvnszn commented Apr 15, 2022

What this PR does:
remove HEADER_LENGTH in decode because of discard
Which issue(s) this PR fixes:
Fixes #

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • After import formatted, (using imports-formatter to run 'imports-formatter .' in project root, to format your import blocks, mentioned in CONTRIBUTING.md above)
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

@Lvnszn Lvnszn force-pushed the 3.0 branch 2 times, most recently from fb2778f to 9e28951 Compare April 15, 2022 06:51
@codecov-commenter
Copy link

Codecov Report

Merging #1831 (9e28951) into 3.0 (605764e) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

❗ Current head 9e28951 differs from pull request most recent head 51d9749. Consider uploading reports for the commit 51d9749 to get more accurate results

@@            Coverage Diff             @@
##              3.0    #1831      +/-   ##
==========================================
- Coverage   46.76%   46.73%   -0.04%     
==========================================
  Files         298      298              
  Lines       17178    17178              
==========================================
- Hits         8034     8028       -6     
- Misses       8291     8296       +5     
- Partials      853      854       +1     
Impacted Files Coverage Δ
protocol/dubbo/impl/codec.go 41.66% <0.00%> (ø)
filter/metrics/filter.go 85.00% <0.00%> (-15.00%) ⬇️
metrics/prometheus/reporter.go 26.85% <0.00%> (-1.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 605764e...51d9749. Read the comment docs.

@AlexStocks AlexStocks merged commit 553c836 into apache:3.0 Apr 16, 2022
@Lvnszn Lvnszn deleted the 3.0 branch May 14, 2022 06:25
@Lvnszn Lvnszn restored the 3.0 branch May 14, 2022 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants