Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo correction #1924

Merged
merged 2 commits into from Jun 10, 2022
Merged

fix: typo correction #1924

merged 2 commits into from Jun 10, 2022

Conversation

zgs225
Copy link
Contributor

@zgs225 zgs225 commented Jun 7, 2022

What this PR does:

Which issue(s) this PR fixes:
Fixes #

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • After import formatted, (using imports-formatter to run 'imports-formatter .' in project root, to format your import blocks, mentioned in CONTRIBUTING.md above)
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

@AlexStocks AlexStocks changed the base branch from master to 3.0 June 8, 2022 12:15
@AlexStocks
Copy link
Contributor

@zgs225 the github apollo config unit test case failed, pls fix it.

ok  	dubbo.apache.org/dubbo-go/v3/config_center	0.006s	coverage: 9.1% of statements
2022-06-08T11:23:11.802Z	INFO	apollo/impl.go:70	[Apollo ConfigCenter] New Apollo ConfigCenter with Configuration: &{AppID:testApplication_yang Cluster:dev NamespaceName:mockDubbogo.yaml IP:http://127.0.0.1:37699/ NextTryConnTime:0 IsBackupConfig:true BackupConfigPath: Secret:}, url = apollo://127.0.0.1:37699?config-center.appId=testApplication_yang&config-center.cluster=dev&config-center.group=&config-center.namespace=mockDubbogo.yaml&config-center.timeout=&remote-client-name=dubbo.config-center-apollo-106.12.25.204%3A8080
2022-06-08T11:23:11.803Z	INFO	apollo/impl.go:70	[Apollo ConfigCenter] New Apollo ConfigCenter with Configuration: &{AppID:testApplication_yang Cluster:dev NamespaceName:mockDubbogo.yaml IP:http://127.0.0.1:37193/ NextTryConnTime:0 IsBackupConfig:true BackupConfigPath: Secret:}, url = apollo://127.0.0.1:37193?config-center.appId=testApplication_yang&config-center.cluster=dev&config-center.group=&config-center.namespace=mockDubbogo.yaml&config-center.timeout=&remote-client-name=dubbo.config-center-apollo-106.12.25.204%3A8080
2022-06-08T11:23:11.804Z	INFO	apollo/impl.go:70	[Apollo ConfigCenter] New Apollo ConfigCenter with Configuration: &{AppID:testApplication_yang Cluster:dev NamespaceName:mockDubbogo.yaml IP:http://127.0.0.1:37649/ NextTryConnTime:0 IsBackupConfig:true BackupConfigPath: Secret:}, url = apollo://127.0.0.1:37649?config-center.appId=testApplication_yang&config-center.cluster=dev&config-center.group=&config-center.namespace=mockDubbogo.yaml&config-center.timeout=&remote-client-name=dubbo.config-center-apollo-106.12.25.204%3A8080
panic: sync: negative WaitGroup counter
goroutine 131 [running]:
sync.(*WaitGroup).Add(0xc0002891d0, 0xffffffffffffffff)
	/opt/hostedtoolcache/go/1.15.15/x64/src/sync/waitgroup.go:74 +0x147
sync.(*WaitGroup).Done(...)
	/opt/hostedtoolcache/go/1.15.15/x64/src/sync/waitgroup.go:99
dubbo.apache.org/dubbo-go/v3/config_center/apollo.(*apolloDataListener).Process(0xc0002891d0, 0xc0005d2c00)
	/home/runner/work/dubbo-go/dubbo-go/config_center/apollo/impl_test.go:213 +0x45
dubbo.apache.org/dubbo-go/v3/config_center/apollo.(*apolloListener).OnNewestChange(0xc000010300, 0xc00011dac0)
	/home/runner/work/dubbo-go/dubbo-go/config_center/apollo/listener.go:58 +0x12d
created by github.com/zouyx/agollo/v3/storage.pushNewestChanges.func1
	/home/runner/go/pkg/mod/github.com/zouyx/agollo/v3@v3.4.5/storage/change_event.go:112 +0x4c
FAIL	dubbo.apache.org/dubbo-go/v3/config_center/apollo	2.025s

@zgs225
Copy link
Contributor Author

zgs225 commented Jun 9, 2022

It seems like internal error which occurs randomly. Could you help to re-run the action?

@zgs225 the github apollo config unit test case failed, pls fix it.

ok  	dubbo.apache.org/dubbo-go/v3/config_center	0.006s	coverage: 9.1% of statements
2022-06-08T11:23:11.802Z	INFO	apollo/impl.go:70	[Apollo ConfigCenter] New Apollo ConfigCenter with Configuration: &{AppID:testApplication_yang Cluster:dev NamespaceName:mockDubbogo.yaml IP:http://127.0.0.1:37699/ NextTryConnTime:0 IsBackupConfig:true BackupConfigPath: Secret:}, url = apollo://127.0.0.1:37699?config-center.appId=testApplication_yang&config-center.cluster=dev&config-center.group=&config-center.namespace=mockDubbogo.yaml&config-center.timeout=&remote-client-name=dubbo.config-center-apollo-106.12.25.204%3A8080
2022-06-08T11:23:11.803Z	INFO	apollo/impl.go:70	[Apollo ConfigCenter] New Apollo ConfigCenter with Configuration: &{AppID:testApplication_yang Cluster:dev NamespaceName:mockDubbogo.yaml IP:http://127.0.0.1:37193/ NextTryConnTime:0 IsBackupConfig:true BackupConfigPath: Secret:}, url = apollo://127.0.0.1:37193?config-center.appId=testApplication_yang&config-center.cluster=dev&config-center.group=&config-center.namespace=mockDubbogo.yaml&config-center.timeout=&remote-client-name=dubbo.config-center-apollo-106.12.25.204%3A8080
2022-06-08T11:23:11.804Z	INFO	apollo/impl.go:70	[Apollo ConfigCenter] New Apollo ConfigCenter with Configuration: &{AppID:testApplication_yang Cluster:dev NamespaceName:mockDubbogo.yaml IP:http://127.0.0.1:37649/ NextTryConnTime:0 IsBackupConfig:true BackupConfigPath: Secret:}, url = apollo://127.0.0.1:37649?config-center.appId=testApplication_yang&config-center.cluster=dev&config-center.group=&config-center.namespace=mockDubbogo.yaml&config-center.timeout=&remote-client-name=dubbo.config-center-apollo-106.12.25.204%3A8080
panic: sync: negative WaitGroup counter
goroutine 131 [running]:
sync.(*WaitGroup).Add(0xc0002891d0, 0xffffffffffffffff)
	/opt/hostedtoolcache/go/1.15.15/x64/src/sync/waitgroup.go:74 +0x147
sync.(*WaitGroup).Done(...)
	/opt/hostedtoolcache/go/1.15.15/x64/src/sync/waitgroup.go:99
dubbo.apache.org/dubbo-go/v3/config_center/apollo.(*apolloDataListener).Process(0xc0002891d0, 0xc0005d2c00)
	/home/runner/work/dubbo-go/dubbo-go/config_center/apollo/impl_test.go:213 +0x45
dubbo.apache.org/dubbo-go/v3/config_center/apollo.(*apolloListener).OnNewestChange(0xc000010300, 0xc00011dac0)
	/home/runner/work/dubbo-go/dubbo-go/config_center/apollo/listener.go:58 +0x12d
created by github.com/zouyx/agollo/v3/storage.pushNewestChanges.func1
	/home/runner/go/pkg/mod/github.com/zouyx/agollo/v3@v3.4.5/storage/change_event.go:112 +0x4c
FAIL	dubbo.apache.org/dubbo-go/v3/config_center/apollo	2.025s

@codecov-commenter
Copy link

Codecov Report

Merging #1924 (6c4d14b) into 3.0 (07defad) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              3.0    #1924      +/-   ##
==========================================
- Coverage   45.02%   44.92%   -0.10%     
==========================================
  Files         287      287              
  Lines       17135    17135              
==========================================
- Hits         7715     7698      -17     
- Misses       8606     8623      +17     
  Partials      814      814              
Impacted Files Coverage Δ
config/reference_config.go 31.97% <0.00%> (ø)
filter/metrics/filter.go 85.00% <0.00%> (-15.00%) ⬇️
metadata/report/delegate/delegate_report.go 26.49% <0.00%> (-7.95%) ⬇️
...tocol/rest/server/server_impl/go_restful_server.go 41.37% <0.00%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07defad...6c4d14b. Read the comment docs.

@AlexStocks AlexStocks merged commit 35f4e8c into apache:3.0 Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants