Fix service discovery related issues and add mesh proxy mode support #2022

chickenlj · 2022-08-18T11:39:21Z

add 'mesh-enabled' property, 'true' means to deploy SDK together with sidecar
make 'registry-type' to support 'service', 'interface', and 'all', representing register instance address, register interface address, and register both respectively. Default behavior is 'service'
fix instance address notification issue

chickenlj · 2022-08-18T11:51:52Z

Samples would be added to dubbo-go-samples soon

config/registry_config.go

.asf.yaml

codecov-commenter · 2022-08-28T10:35:56Z

Codecov Report

Merging #2022 (3c7a964) into 3.1 (19ddecf) will decrease coverage by 0.02%.
The diff coverage is 40.62%.

❗ Current head 3c7a964 differs from pull request most recent head ea88557. Consider uploading reports for the commit ea88557 to get more accurate results

@@            Coverage Diff             @@
##              3.1    #2022      +/-   ##
==========================================
- Coverage   44.60%   44.58%   -0.03%     
==========================================
  Files         283      283              
  Lines       17105    17215     +110     
==========================================
+ Hits         7630     7675      +45     
- Misses       8669     8730      +61     
- Partials      806      810       +4

Impacted Files	Coverage Δ
common/extension/metadata_report_factory.go	`0.00% <0.00%> (ø)`
common/metadata_info.go	`0.00% <0.00%> (ø)`
config/config_loader.go	`17.33% <0.00%> (-0.24%)`	⬇️
config/consumer_config.go	`22.04% <0.00%> (-0.54%)`	⬇️
config/metadata_report_config.go	`64.19% <0.00%> (ø)`
config/reference_config.go	`28.63% <0.00%> (-3.35%)`	⬇️
config/service_config.go	`52.25% <ø> (-0.80%)`	⬇️
...y/event/service_instances_changed_listener_impl.go	`0.00% <0.00%> (ø)`
registry/service_instance.go	`0.00% <0.00%> (ø)`
...try/servicediscovery/service_discovery_registry.go	`1.24% <0.00%> (-0.04%)`	⬇️
... and 13 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

chickenlj · 2022-08-29T02:34:00Z

apache/dubbo-go-samples#411

Merge this pull request first to pass the CI.

Mulavar · 2022-08-29T03:11:42Z

please squash your commits with git rebase.

config/registry_config.go

chickenlj · 2022-08-29T07:23:29Z

please squash your commits with git rebase.

Why is this necessary? I think 'squash and merge' would do the same thing for us if you worry too many commits would be brought in the repo after merging, it will compose all commits into one commit and the only thing that needs to do when using that is to replace the commit record listed there to one single conclusion.

Mulavar · 2022-08-29T14:15:14Z

the only thing that needs to do when using that is to replace the commit record listed there to one single conclusion.
yeah, that's what I want to mean. If you think this is not a problem, I am Ok with this.

remoting/zookeeper/curator_discovery/service_discovery.go

common/metadata_info.go

common/extension/metadata_report_factory.go

config/registry_config.go

chickenlj · 2022-09-01T11:34:18Z

Kindly remind: please use 'Squash and Merge' when merging.

.asf.yaml

baerwang · 2022-09-16T02:16:55Z

common/url.go

+		ok = false
+	}
+
+	return r, ok


这个是不是多余了？直接判断是否为空字符串不就好了吗？

return r, r == ""

AlexStocks · 2022-09-24T02:09:08Z

common/url.go

@@ -515,6 +530,23 @@ func (c *URL) GetParam(s string, d string) string {
 	return r
 }

+// GetParamNoDefault gets value by key, return nil,false if no value found mapping to the key
+func (c *URL) GetParamNoDefault(s string) (string, bool) {


这个函数名气很奇怪。在Go里面，我们知道map之类的会有一些default值，所以我大概也能明白你的用意。但 (string, bool) 中的 bool 就是 go 的风格，能够说明 key 是否存在，所以改名叫 GetParam 就可以了。

改名叫 GetParam 就可以

GetParam 这个名字已经被占用了，并且没有 bool 返回值，没啥好办法了。

You might consider using GetParamWithoutDefault to replace that.

GetNonDefaultParam怎么样

GetNonDefaultParam怎么样

Agree with u. Really a better func name.

Xezeloh · 2022-09-27T05:07:36Z

GetNonDefaultParam

chickenlj added 6 commits August 18, 2022 15:40

fix service discovery related issues and add mesh proxy mode

2377ea9

fix wrong condition check

39e31d0

delete useless code

1a5918c

delete empty if branch

113c921

fix service discovery

645dd64

fix unexpected change

e9b728e

AlexStocks reviewed Aug 18, 2022

View reviewed changes

config/registry_config.go Outdated Show resolved Hide resolved

chickenlj added 6 commits August 18, 2022 20:02

remove unused code

b17a8d0

fix shadow variable

f368295

add comment

2c42119

recover provided_by

e31102a

add project setting

a2a62c4

update

096db6a

AlexStocks reviewed Aug 18, 2022

View reviewed changes

.asf.yaml Outdated Show resolved Hide resolved

AlexStocks reviewed Aug 18, 2022

View reviewed changes

.asf.yaml Outdated Show resolved Hide resolved

chickenlj added 14 commits August 23, 2022 16:31

Merge branch '3.0' into fix-3.0-mesh-proxy

5e98864

update project description

af62e4d

format imports

f271881

format import

4d61cf9

reformat import using goformatter-imports

82f236a

enable default metadata

a668a23

fix compilation

48fe0cb

skip if metadata factory not provided

8f26c34

add some logs

d74775b

delete previous instance if exists

86a1040

consume tri protocol by default

78bff0c

change IT repo

8f832be

fix

69d164d

fix directory subscribe

5c1fd14

fix service discovery

01f06e2

chickenlj added the do not merge label Aug 28, 2022

fix service discovery, ignore err when checking mapping

d96b220

recover integration test configuration

3c7a964

chickenlj removed the do not merge label Aug 29, 2022

Mulavar reviewed Aug 29, 2022

View reviewed changes

config/registry_config.go Show resolved Hide resolved

Mulavar approved these changes Aug 29, 2022

View reviewed changes

AlexStocks reviewed Aug 30, 2022

View reviewed changes

remoting/zookeeper/curator_discovery/service_discovery.go Outdated Show resolved Hide resolved

binbin0325 reviewed Aug 30, 2022

View reviewed changes

common/metadata_info.go Outdated Show resolved Hide resolved

common/extension/metadata_report_factory.go Outdated Show resolved Hide resolved

config/registry_config.go Outdated Show resolved Hide resolved

config/registry_config.go Show resolved Hide resolved

chickenlj added 3 commits August 31, 2022 13:30

support 'N/A' registry address

5ee0a81

support 'N/A' registry address

741f579

fix log format

d6d59ae

chickenlj added 2 commits September 6, 2022 16:05

Optimze code according to comments

dd2f59f

update base branch

ea88557

justxuewei reviewed Sep 8, 2022

View reviewed changes

.asf.yaml Show resolved Hide resolved

AlexStocks approved these changes Sep 8, 2022

View reviewed changes

baerwang reviewed Sep 16, 2022

View reviewed changes

AlexStocks reviewed Sep 24, 2022

View reviewed changes

AlexStocks merged commit 73efc8c into apache:3.1 Sep 29, 2022

chickenlj deleted the fix-3.0-mesh-proxy branch November 4, 2022 04:58

zhaoyunxing92 mentioned this pull request Nov 25, 2022

[Enhancement] registry type support all #2095

Open

chickenlj restored the fix-3.0-mesh-proxy branch March 27, 2023 10:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix service discovery related issues and add mesh proxy mode support #2022

Fix service discovery related issues and add mesh proxy mode support #2022

chickenlj commented Aug 18, 2022 •

edited

chickenlj commented Aug 18, 2022

codecov-commenter commented Aug 28, 2022 •

edited

chickenlj commented Aug 29, 2022

Mulavar commented Aug 29, 2022

chickenlj commented Aug 29, 2022

Mulavar commented Aug 29, 2022

chickenlj commented Sep 1, 2022

baerwang Sep 16, 2022

AlexStocks Sep 24, 2022

AlexStocks Sep 24, 2022

chickenlj Sep 27, 2022

justxuewei Sep 27, 2022

Xezeloh Sep 27, 2022

AlexStocks Sep 27, 2022

Xezeloh commented Sep 27, 2022

Fix service discovery related issues and add mesh proxy mode support #2022

Fix service discovery related issues and add mesh proxy mode support #2022

Conversation

chickenlj commented Aug 18, 2022 • edited

chickenlj commented Aug 18, 2022

codecov-commenter commented Aug 28, 2022 • edited

Codecov Report

chickenlj commented Aug 29, 2022

Mulavar commented Aug 29, 2022

chickenlj commented Aug 29, 2022

Mulavar commented Aug 29, 2022

chickenlj commented Sep 1, 2022

baerwang Sep 16, 2022

Choose a reason for hiding this comment

AlexStocks Sep 24, 2022

Choose a reason for hiding this comment

AlexStocks Sep 24, 2022

Choose a reason for hiding this comment

chickenlj Sep 27, 2022

Choose a reason for hiding this comment

justxuewei Sep 27, 2022

Choose a reason for hiding this comment

Xezeloh Sep 27, 2022

Choose a reason for hiding this comment

AlexStocks Sep 27, 2022

Choose a reason for hiding this comment

Xezeloh commented Sep 27, 2022

chickenlj commented Aug 18, 2022 •

edited

codecov-commenter commented Aug 28, 2022 •

edited